Update comparePromises to capture execution duration metrics#38
Merged
wurdum merged 1 commit intonethermindfrom Oct 31, 2025
Merged
Update comparePromises to capture execution duration metrics#38wurdum merged 1 commit intonethermindfrom
wurdum merged 1 commit intonethermindfrom
Conversation
wurdum
requested review from
AnkushinDaniil,
damian-orzechowski,
hudem1,
svlachakis and
tanishqjasoria
AnkushinDaniil
approved these changes
Oct 31, 2025
AnkushinDaniil
added a commit
that referenced
this pull request
Nov 3, 2025
Incorporates 14 commits from remote nethermind branch: - Prometheus pushgateway support (#37) - Comparison mode for system tests (#36) - Mainnet configuration changes (#34) - comparePromises execution duration metrics (#38) Resolved conflicts in: - Makefile: Added make targets for running follower/sequencer nodes - cmd/genericconf/server.go: Added PrometheusPushgatewayConfig, fixed pflag usage - cmd/nitro/nitro.go: Added execution mode detection and prometheus pushgateway initialization - execution/gethexec/node.go: Added nethermind configuration fields - system_tests/common_test.go: Added execution client mode selection logic - system_tests/execution_client_only_test.go: Added executionClientMode parameter 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.