Conversation
|
For my understanding, so, what this essentially does is fetch the start block data from NMC and set it to some consensus db. And this is enough for nitro to pick up from that block and continue as usual, meaning fetch the next blocks from L1 to send to NMC for execution ? If so, then NMC has to use its internal comparison mode to make sure the block hashes its computing are consistent with l1, right ? |
Yes, your understanding is correct. After bootstrap:
|
Oh okay nitro validates ? validates what exactly ? i mean, the block hashes validation was done by the compare client implem |
Nothing - I got confused. In external mode nitro doesn't validate it works only as consensus |
| } | ||
|
|
||
| // Verify target block exists in Nethermind | ||
| targetBlock, err := createGenesisFromExecution(ctx, config.Execution.NethermindUrl, |
There was a problem hiding this comment.
I think config at execution level should be more general - so ExternalUrl instead of NethermindUrl
|
@damian-orzechowski as discussed on slack merging as is and we can change them later if needed |
Incorporates 14 commits from remote nethermind branch: - Prometheus pushgateway support (#37) - Comparison mode for system tests (#36) - Mainnet configuration changes (#34) - comparePromises execution duration metrics (#38) Resolved conflicts in: - Makefile: Added make targets for running follower/sequencer nodes - cmd/genericconf/server.go: Added PrometheusPushgatewayConfig, fixed pflag usage - cmd/nitro/nitro.go: Added execution mode detection and prometheus pushgateway initialization - execution/gethexec/node.go: Added nethermind configuration fields - system_tests/common_test.go: Added execution client mode selection logic - system_tests/execution_client_only_test.go: Added executionClientMode parameter 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
The point of this PR is to start Nitro from block 22million+ which is Arbitrum One first block, but without having users to load the 32GB pebble genesis state of nitro.
Refactored our custom env variables to config properties.