Resolves Issue #57 - Add Bulk{Write, Read} to NDBench. #64
Conversation
| * @return a list of response codes | ||
| * @throws Exception | ||
| */ | ||
| public List<String> readBulk(final List<String> keys) throws Exception { |
There was a problem hiding this comment.
Why do we care to implement bulk operations in the current plugins?
There was a problem hiding this comment.
just retrofitting to existing plugins. Alternatively we can throw a UnsupportedOperationException.
There was a problem hiding this comment.
Lets throw UnsupportedOperationException so that plugin owners can implement based on what they are looking for
|
How is |
|
@ipapapa I see the bulk to be a series of single read / write. Hence i am returning a list of responses. If we would like to see the entire batch as one unit of work, we should return one single response instead. thoughts? |
| * @return a list of response codes | ||
| * @throws Exception | ||
| */ | ||
| public List<String> readBulk(final List<String> keys) throws Exception { |
There was a problem hiding this comment.
The implementation might be different in C* instead of merging single read operation. There is multiget thrift operation which is more suitable in this case, hence, I would leave the implementation to null and fix later.
There was a problem hiding this comment.
+1. The only plugin that leverage the bulk api would be the janusgraph. i will leave the rest of the plugins as null impl and throw an exception if triggers
| List<String> responses = new ArrayList<>(keys.size()); | ||
| for (String key : keys) { | ||
| String response = writeSingle(key); | ||
| responses.add(response); |
There was a problem hiding this comment.
Batch write is what we needed here.
| List<String> responses = new ArrayList<>(keys.size()); | ||
| for (String key : keys) { | ||
| String response = readSingle(key); | ||
| responses.add(response); |
There was a problem hiding this comment.
Similar to astyanax comments.
| * @return a list of response codes | ||
| * @throws Exception | ||
| */ | ||
| public List<String> readBulk(final List<String> keys) throws Exception { |
There was a problem hiding this comment.
Lets throw UnsupportedOperationException so that plugin owners can implement based on what they are looking for
# Conflicts: # ndbench-cass-plugins/src/main/java/com/netflix/ndbench/plugin/cass/CassJavaDriverPlugin.java
Resolves Issue #57