Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting writeBulk and readBulk #57

Open
pencal opened this issue Oct 26, 2017 · 2 comments
Open

Supporting writeBulk and readBulk #57

pencal opened this issue Oct 26, 2017 · 2 comments

Comments

@pencal
Copy link
Contributor

pencal commented Oct 26, 2017

I am thinking about adding writeBulk and readBulk operations to ndbench. My thought is to add the bulkSize parameter in startWrites and startReads and default it to 1, which falls back to writeSingle and readSingle. Any comments?

pencal added a commit to pencal/ndbench that referenced this issue Nov 24, 2017
@buildlackey
Copy link
Contributor

To keep things consistent we'd have to update Elastic search plugin to use the new 'bulkSize' parameter instead of the getBulkWriteBatchSize() param that it now uses. Also.. I am implementing writeSingle for elastic search such that it actually does bulk write based on getBulkWriteBatchSize(). If this change goes in we should file a bug to do the work to make ES_REST plugin consistent w/ this new approach.

@buildlackey
Copy link
Contributor

I would recommend NOT closing this bug until the above issue is addressed.. Otherwise things will get inconsistent.

pencal added a commit to pencal/ndbench that referenced this issue Dec 11, 2017
ipapapa pushed a commit that referenced this issue Feb 8, 2018
* Issue #57

* Issue #57 - addressed review comments
vinaykumarchella added a commit to vinaykumarchella/ndbench that referenced this issue Apr 9, 2018
… and cache miss after merging Netflix#57 (Bulk request support)
vinaykumarchella added a commit that referenced this issue Apr 9, 2018
…cache hit and cache miss after merging #57 (Bulk request support) (#136)

Bug fix: read operation return values are not respected for cache hit and cache miss after merging #57 (Bulk request support)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants