-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metaflow Configs #1962
Open
romain-intel
wants to merge
15
commits into
master
Choose a base branch
from
feat/configs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Metaflow Configs #1962
+1,470
−154
Commits on Sep 10, 2024
-
Change top-level flow decorator options to be prefixed by METAFLOW_FLOW_
Previously, options like `branch` and `name` (injected by the project decorator for example) could be set using `METAFLOW_BRANCH`. They now need to be set using `METAFLOW_FLOW_BRANCH`. This change is made to prevent clashes between regular metaflow configuration settings and decorator level options. No other changes are made so `METAFLOW_RUN_MAX_WORKERS` still works as expected and `METAFLOW_PYLINT` as well.
Configuration menu - View commit details
-
Copy full SHA for 931d310 - Browse repository at this point
Copy the full SHA 931d310View commit details -
Configuration menu - View commit details
-
Copy full SHA for 688b561 - Browse repository at this point
Copy the full SHA 688b561View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b1c59b - Browse repository at this point
Copy the full SHA 1b1c59bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f3cb39 - Browse repository at this point
Copy the full SHA 4f3cb39View commit details -
Configuration menu - View commit details
-
Copy full SHA for e285785 - Browse repository at this point
Copy the full SHA e285785View commit details -
Several fixes: - fixed an issue with default values - better handling of parameter defaults as configs - handle config defaults as functions - ConfigValue is more "dict"-like - made <myflow>.configs and <myflow>.steps work properly - renamed resolve_configs to init
Configuration menu - View commit details
-
Copy full SHA for 8b6214a - Browse repository at this point
Copy the full SHA 8b6214aView commit details -
Addressed comments. Added more documentation/explanation
Specifically: - moved things out of the INFO file - added to_dict - renamed user_configs to config_parameters
Configuration menu - View commit details
-
Copy full SHA for 5f354b1 - Browse repository at this point
Copy the full SHA 5f354b1View commit details -
Specifically: - made config values immutable - cleaned up state stored in FlowSpec - added a test exercising configs in various places
Configuration menu - View commit details
-
Copy full SHA for bcdd987 - Browse repository at this point
Copy the full SHA bcdd987View commit details -
Configuration menu - View commit details
-
Copy full SHA for d00fe98 - Browse repository at this point
Copy the full SHA d00fe98View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9592600 - Browse repository at this point
Copy the full SHA 9592600View commit details -
Fix the dreadful core tests and be a LOT less verbose
Will only print stuff when there is an error and will print it in a non-interleaved manner.
Configuration menu - View commit details
-
Copy full SHA for f6fdc69 - Browse repository at this point
Copy the full SHA f6fdc69View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6370ff2 - Browse repository at this point
Copy the full SHA 6370ff2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 39b31de - Browse repository at this point
Copy the full SHA 39b31deView commit details -
Configuration menu - View commit details
-
Copy full SHA for dad4707 - Browse repository at this point
Copy the full SHA dad4707View commit details
Commits on Sep 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f172725 - Browse repository at this point
Copy the full SHA f172725View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.