-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metaflow Configs #1962
base: master
Are you sure you want to change the base?
Metaflow Configs #1962
Conversation
b03a453
to
de97829
Compare
As a user interested in using a config file instead of using different sets of parameters, what would a config file look like? |
@bhogan-bdai -- the idea so far is to support a simple format like JSON (nested dicts basically) but other formats could be supported as well. We are also providing a |
Previously, options like `branch` and `name` (injected by the project decorator for example) could be set using `METAFLOW_BRANCH`. They now need to be set using `METAFLOW_FLOW_BRANCH`. This change is made to prevent clashes between regular metaflow configuration settings and decorator level options. No other changes are made so `METAFLOW_RUN_MAX_WORKERS` still works as expected and `METAFLOW_PYLINT` as well.
Several fixes: - fixed an issue with default values - better handling of parameter defaults as configs - handle config defaults as functions - ConfigValue is more "dict"-like - made <myflow>.configs and <myflow>.steps work properly - renamed resolve_configs to init
Specifically: - moved things out of the INFO file - added to_dict - renamed user_configs to config_parameters
Specifically: - made config values immutable - cleaned up state stored in FlowSpec - added a test exercising configs in various places
a4b601d
to
bcdd987
Compare
Will only print stuff when there is an error and will print it in a non-interleaved manner.
This is not yet fully ready but putting out so people can get a general sense of the direction.