Skip to content

Remove cautious_mask leftovers - #1451

Merged
dxqb merged 1 commit into
Nerogar:mergefrom
Koratahiu:remove_cautious
May 13, 2026
Merged

Remove cautious_mask leftovers#1451
dxqb merged 1 commit into
Nerogar:mergefrom
Koratahiu:remove_cautious

Conversation

@Koratahiu

Copy link
Copy Markdown
Contributor

Removed leftovers from #1363 (for Lion_adv).
Resolves #1441.

@dxqb
dxqb changed the base branch from master to merge May 13, 2026 20:50
@dxqb
dxqb merged commit a2e26ff into Nerogar:merge May 13, 2026
1 check passed
dxqb pushed a commit that referenced this pull request May 29, 2026
Brings in upstream changes (remove COFT #1447, remove cautious_mask #1451,
fix aux optimizer defaults #1444). Conflicts resolved by keeping the
ctk_abstraction refactored versions (self.components, controller delegation).
COFT removal applied manually to BaseLoraTabView.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
BitcrushedHeart pushed a commit to BitcrushedHeart/OneTrainer that referenced this pull request Jun 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: AttributeError: 'TrainOptimizerConfig' object has no attribute 'cautious_mask'

2 participants