Fix: apply aux optimizer defaults when current_state is empty - #1444
Merged
Conversation
`current_state is None` missed the case where state is an empty dict, causing MuonWithAuxAdam to show blank fields instead of defaults on first open. Changed to `not current_state` to cover both cases.
Collaborator
Author
|
@Koratahiu could you review |
dxqb
pushed a commit
that referenced
this pull request
May 29, 2026
Brings in upstream changes (remove COFT #1447, remove cautious_mask #1451, fix aux optimizer defaults #1444). Conflicts resolved by keeping the ctk_abstraction refactored versions (self.components, controller delegation). COFT removal applied manually to BaseLoraTabView. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
BitcrushedHeart
pushed a commit
to BitcrushedHeart/OneTrainer
that referenced
this pull request
Jun 20, 2026
dxqb
added a commit
to dxqb/OneTrainer
that referenced
this pull request
Jun 27, 2026
…tk view split The ctk view split copied OptimizerParamsWindow into a controller from a base that predated Nerogar#1444, reverting `if not current_state:` back to `if current_state is None:`. Since muon_adam_config defaults to {} (not None), the empty initial state fell through to from_dict({}), so the Muon/aux-Adam window opened with bare default_values() instead of MUON_AUX_ADAM_DEFAULTS / ADAMW_ADV. Restore the upstream one-line guard. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OptimizerParamsWindowcheckedcurrent_state is Nonebefore populating defaults, butcurrent_statecan also be an empty dict{}when no config has been saved yetnot current_stateso defaults are applied for bothNoneand empty stateTest plan