Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure setuptools and wheel are installed & up-to-date in CI unit tests #573

Merged
merged 2 commits into from
Feb 16, 2022

Conversation

juhoinkinen
Copy link
Member

The wheel package has not been available for dependency installations for unit tests in GH Actions runs. There has been messages like
Using legacy 'setup.py install' for pyrsistent, since package 'wheel' is not installed.

Installing wheel gets rid of the messages, possibly also making dependency installations faster.

This PR also makes sure setuptools is updated, making dependency installation environment the same as in building Dockerfile.

This issue came into attention via a comment in #572.

@juhoinkinen juhoinkinen added this to the 0.57 milestone Feb 16, 2022
@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #573 (a2cfdbc) into master (7f4fc02) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #573   +/-   ##
=======================================
  Coverage   99.47%   99.47%           
=======================================
  Files          84       84           
  Lines        5568     5568           
=======================================
  Hits         5539     5539           
  Misses         29       29           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f4fc02...a2cfdbc. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Feb 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@osma osma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@juhoinkinen juhoinkinen merged commit d0f84ae into master Feb 16, 2022
@juhoinkinen juhoinkinen deleted the gh-actions-ensure-setuptools-update branch February 16, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants