Update Dockerfile v0.57 #572
Conversation
juhoinkinen
commented
Feb 16, 2022
juhoinkinen
commented
- Install rsync to allow transferring models to OpenShift environment
- Ensure pip & setuptools are updated when building
- Install voikko system packages only if Voikko is included in optional dependencies
- Remove retry loop for nltk data download (hopefully not needed anymore, as the network problems encountered in Drone should not exist in GH Actions)
Codecov Report
@@ Coverage Diff @@
## master #572 +/- ##
=======================================
Coverage 99.47% 99.47%
=======================================
Files 84 84
Lines 5568 5568
=======================================
Hits 5539 5539
Misses 29 29 Continue to review full report at Codecov.
|
Dockerfile
Outdated
| @@ -9,6 +9,7 @@ RUN if [[ $optional_dependencies =~ "fasttext" ]]; then \ | |||
| apt-get update && \ | |||
| apt-get install -y --no-install-recommends \ | |||
| build-essential && \ | |||
| pip install --upgrade pip setuptools --no-cache-dir && \ | |||
There was a problem hiding this comment.
Would it make sense to install wheel here as well? In my understanding, it might speed up installation of some Python packages - they can be installed from prebuilt wheels instead of rebuilt. Not sure if that is relevant for the Annif dependencies though.
There was a problem hiding this comment.
Yes it would. When installing deps for unit test runs in GH Action, there are messages like
Using legacy 'setup.py install' for xxx, since package 'wheel' is not installed.
I was confused as I did not see these messages in Docker builds, but that was just because wheel actually was available as it got installed as a dependency (of TensorFlow?).
(I'll install wheel also for unit test runs.)
Dockerfile
Outdated
|
|
||
| WORKDIR /Annif | ||
| RUN pip install --upgrade pip --no-cache-dir | ||
| RUN pip install --upgrade pip setuptools --no-cache-dir |
There was a problem hiding this comment.
Or maybe this would be a better place for wheel...
|
Kudos, SonarCloud Quality Gate passed!
|
