CraterCrashGH-670 Fix reset pin to default value

Naros · Sep 8, 2024 · 908f298 · 908f298
1 parent 7c1df18
commit 908f298
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/src/script/node_pin.cpp b/src/script/node_pin.cpp
@@ -294,7 +294,10 @@ void OScriptNodePin::set_type(Variant::Type p_type)
         _property.type = p_type;
 
         if (_set_type_resets_default)
-            reset_default_value();
+        {
+            _default_value = Variant();
+            _generated_default_value = _target_class.is_empty() ? VariantUtils::make_default(_property.type) : Variant();
+        }
 
         emit_changed();
     }
@@ -320,7 +323,10 @@ void OScriptNodePin::set_target_class(const StringName& p_target_class)
             _property.type = Variant::OBJECT;
 
         if (_set_type_resets_default)
-            reset_default_value();
+        {
+            _default_value = Variant();
+            _generated_default_value = _target_class.is_empty() ? VariantUtils::make_default(_property.type) : Variant();
+        }
 
         emit_changed();
     }
@@ -351,8 +357,7 @@ void OScriptNodePin::set_default_value(const Variant& p_default_value)
 
 void OScriptNodePin::reset_default_value()
 {
-    _default_value = Variant();
-    _generated_default_value = _target_class.is_empty() ? VariantUtils::make_default(_property.type) : Variant();
+    set_default_value(_generated_default_value);
 }
 
 Variant OScriptNodePin::get_generated_default_value() const

diff --git a/src/script/nodes/functions/call_function.cpp b/src/script/nodes/functions/call_function.cpp
@@ -332,7 +332,10 @@ void OScriptNodeCallFunction::_create_pins_for_method(const MethodInfo& p_method
             }
 
             if (argument_index >= default_start_index)
+            {
+                pin->set_generated_default_value(p_method.default_arguments[default_index]);
                 pin->set_default_value(p_method.default_arguments[default_index++]);
+            }
         }
         argument_index++;
     }