Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset to default value doesn't always work #670

Closed
Naros opened this issue Aug 4, 2024 · 0 comments · Fixed by #805
Closed

Reset to default value doesn't always work #670

Naros opened this issue Aug 4, 2024 · 0 comments · Fixed by #805
Labels
bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 cherrypick:2.1 Requires cherry-pick to Orchestrator 2.1 kind/bug A bug or regression in expected behavior.
Milestone

Comments

@Naros
Copy link
Member

Naros commented Aug 4, 2024

Describe the bug

For example, the PrintString node uses a default value 2 for duration; however, the Reset to Default Value context-menu option on the pin resets the value back to 0.

The Reset to Default Value uses the get_generated_default_value() pin function to know what to reset the value to; however, this is always populated with the Variant's default initial "zero" value, and for a float this is 0.

Perhaps the create_pin function can take one additional argument, the "generated default value", which will be set as the generated default value for use cases where the default value is explicitly not the "zero" value for the pin type?

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Godot full version

No response

Orchestrator version

2.1

Additional information

No response

@Naros Naros added kind/bug A bug or regression in expected behavior. bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 cherrypick:2.1 Requires cherry-pick to Orchestrator 2.1 labels Aug 4, 2024
@Naros Naros added this to the 2.2 milestone Aug 4, 2024
Naros added a commit to Naros/godot-orchestrator that referenced this issue Sep 8, 2024
Naros added a commit that referenced this issue Sep 8, 2024
@Naros Naros closed this as completed in #805 Sep 8, 2024
Naros added a commit to Naros/godot-orchestrator that referenced this issue Sep 8, 2024
Naros added a commit to Naros/godot-orchestrator that referenced this issue Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 cherrypick:2.1 Requires cherry-pick to Orchestrator 2.1 kind/bug A bug or regression in expected behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant