Repository navigation
feat: enable Dynamo lifecycle OTel capture by default - #598
Merged
Merged
Conversation
Signed-off-by: Yuewei Na <nv-yna@users.noreply.github.com>
Signed-off-by: Yuewei Na <nv-yna@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #598 +/- ##
=======================================
Coverage ? 85.23%
=======================================
Files ? 162
Lines ? 23247
Branches ? 0
=======================================
Hits ? 19814
Misses ? 3433
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
nv-yna
marked this pull request as ready for review
October 12, 2026 10:33
nv-yna
requested review from
alec-flowers,
csahithi,
hjjq,
ishandhanani,
kedarpotdar-nv,
kyleliang-nv,
nlevin-ui and
qiching
as code owners
October 12, 2026 10:33
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dynamo recipes currently require explicit lifecycle and OTLP environment settings plus a separately configured collector to save native request-lifecycle traces. Enable this capture automatically for the Dynamo stack, including when
observability.enabledis false or omitted.logs/otel/for DSight.make setup ARCH=<compute_arch>; show it in dry-run output. Document service overrides and update the affected launch snapshots.Requires a Dynamo build containing native lifecycle instrumentation (ai-dynamo/dynamo#14101). This does not upgrade a recipe's pinned Dynamo version. Existing installations need
make setupto install the new collector binary.Validation:
make checkpassed (4,437 tests), a real OTLP/gRPC export and shutdown-flush smoke test passed, and all PR CI checks passed.Two successful AgentX runs on Lyris GB200 (Qwen3.5-9B, SGLang TP2, AIPerf 0.12.0, Dynamo 1.6.0.dev20261007), each with a 30-minute walltime limit. Both recipes omit
enable_otel,otel_endpointandDYN_LIFECYCLE_TRACE_ENABLED:Both runs reported zero client errors. Real Chromium browser checks passed for both portable DSight reports: lifecycle expansion, TTFT zoom, native worker admission/dispatch/streaming activities, pinned GPU metrics (402 metric families), and zero JavaScript errors. The enabled case also rendered aligned frontend Nsight ranges beside the selected request and OTel spans: two profile catalogs imported, 31 selected frontend NVTX ranges, 5 ranges in the checked TTFT window. The worker profile had no selected DSight ranges; CPU samples were not collected.
Validation limitation: the initial enabled run 3316479 completed its requests but timed out during Nsight CPU-capture shutdown. The successful retry retained NVTX profiling with
observability.nsys.cpu_sampling: noneand a 120s report timeout. These are short diagnostic AgentX runs (submission_valid=false), not a performance or overhead comparison. No profiler implementation changes are included.Run artifacts and per-run reports:
/lustre/fsw/coreai_comparch_aarwlt/yna/lifecycle-otel-default-20261012/outputs/{3316476,3316539}/. Reproduction script, browser assertions/screenshots and saved report views:/home/yna/code/tmp_context/observability/dsight/20261012-always-on-lifecycle-otel/.