Skip to content

fix(byoo): avoid duplicate metric subset labels #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kristinapathak merged 1 commit into from
Jul 29, 2026
Merged

fix(byoo): avoid duplicate metric subset labels #535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/compute-plane-services/byoo-otel-collector/VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.157.2
0.157.3
2 changes: 0 additions & 2 deletions ...byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_metric_subset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,6 @@ exporters:
enable_open_metrics: true
endpoint: ${env:OTEL_POD_IP:-0.0.0.0}:19091
metric_expiration: 5m
resource_to_telemetry_conversion:
enabled: true
send_timestamps: true
prometheus_remote_write/PROMETHEUS-workload-metrics-metrics:
endpoint: https://workload-metrics.example.invalid/api/v1/write
Expand Down
5 changes: 1 addition & 4 deletions src/compute-plane-services/byoo-otel-collector/internal/otelconfig/render.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,10 +542,7 @@ func addWorkloadMetricsDropLabelsProcessor(otelConfig *OpenTelemetryConfig, labe

func addMetricSubsetExporter(otelConfig *OpenTelemetryConfig) {
otelConfig.Exporters[metricSubsetExporterID] = map[string]interface{}{
"endpoint": fmt.Sprintf("${env:OTEL_POD_IP:-0.0.0.0}:%d", defaultMetricSubsetPort),
"resource_to_telemetry_conversion": map[string]interface{}{
"enabled": true,
},
"endpoint": fmt.Sprintf("${env:OTEL_POD_IP:-0.0.0.0}:%d", defaultMetricSubsetPort),
"send_timestamps": true,
"metric_expiration": "5m",
"enable_open_metrics": true,
Expand Down
5 changes: 1 addition & 4 deletions src/compute-plane-services/byoo-otel-collector/internal/otelconfig/render_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -727,10 +727,7 @@ func TestGenerateExportersAndServiceAddsMetricSubsetPipeline(t *testing.T) {

assert.NoError(t, err)
assert.Equal(t, map[string]interface{}{
"endpoint": "${env:OTEL_POD_IP:-0.0.0.0}:19091",
"resource_to_telemetry_conversion": map[string]interface{}{
"enabled": true,
},
"endpoint": "${env:OTEL_POD_IP:-0.0.0.0}:19091",
"send_timestamps": true,
"metric_expiration": "5m",
"enable_open_metrics": true,
Expand Down
Loading