fix(byoo): avoid duplicate metric subset labels - #535
Merged
kristinapathak merged 1 commit intoJul 29, 2026
Conversation
📝 WalkthroughWalkthroughThe metric subset Prometheus exporter no longer enables resource-to-telemetry conversion. The rendered configuration, Kubernetes example, and test expectations are updated, and the collector version is incremented to ChangesMetric subset exporter
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Refs #534 Signed-off-by: Kristina Pathak <kpathak@nvidia.com>
kristinapathak
force-pushed
the
kpathak/fix-byoo-prometheus-duplicate-labels
branch
from
July 29, 2026 19:33
8dfbf93 to
e9d2b0c
Compare
sbaum1994
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Disable resource-to-telemetry conversion in the Prometheus-only BYOO metric-subset exporter so required BYOO metric labels have one source.
Additional Details
resourcecleanup andmetrics_transform.metrics_transforminjects required NVCF metadata from environment variables, including NCA, provider, instance, host, function/version, region or zone, origin, and task identifiers.function.idtofunction_id, which collides with the transform-created label of the same name.For the Reviewer
Review
addMetricSubsetExporterand the metric-subset pipeline insrc/compute-plane-services/byoo-otel-collector/internal/otelconfig/render.go.For QA
GOCACHE=/private/tmp/byoo-prometheus-labels-go-cache go test ./internal/otelconfig -count=1GOCACHE=/private/tmp/byoo-prometheus-labels-go-cache go test ./...GOCACHE=/private/tmp/byoo-prometheus-labels-go-cache make validate-otelconfigwas attempted. The localotelcolbuild exceeded five minutes before config validation began.QA is not needed for this generated configuration change.
Issues
Fixes #534
Checklist
Summary by CodeRabbit
resource_to_telemetry_conversion.