Skip to content

Conversation

@cpcloud
Copy link
Contributor

@cpcloud cpcloud commented Jan 29, 2026

This PR is a cursor-driven modernization, removing object subclassing (unnecessary since 2.2 (!)) as well as cleaning up unnecessary arguments to super() calls.

Use zero-arg super() where self was passed explicitly.
Use implicit object inheritance in class declarations.
@copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 29, 2026

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@cpcloud
Copy link
Contributor Author

cpcloud commented Jan 29, 2026

/ok to test

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 29, 2026

Greptile Overview

Greptile Summary

This PR modernizes the codebase by removing explicit object base classes (unnecessary since Python 2.2) and simplifying super() calls to use the zero-argument form introduced in Python 3. The changes span 93 files across the entire numba-cuda codebase, affecting hundreds of class definitions and super() calls.

Key changes:

  • Removed explicit object inheritance from class definitions (e.g., class Foo(object):class Foo:)
  • Simplified super() calls from super(ClassName, self).__init__(...) to super().__init__(...)
  • Applied consistently across core compiler infrastructure, type system, CUDA driver bindings, simulators, and test suites

All changes follow standard Python 3 modernization patterns and maintain equivalent behavior.

Confidence Score: 5/5

  • This PR is safe to merge with no concerns
  • This is a straightforward Python modernization refactor applying well-established patterns. All changes (removing explicit object bases and simplifying super() calls) are syntactic improvements that maintain identical runtime behavior in Python 3. The transformations are mechanical and low-risk.
  • No files require special attention

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@cpcloud cpcloud enabled auto-merge (squash) January 29, 2026 18:03
@cpcloud cpcloud merged commit c05a530 into NVIDIA:main Jan 30, 2026
206 of 208 checks passed
gmarkall added a commit to gmarkall/numba-cuda that referenced this pull request Feb 5, 2026
- Add CUDA FP8 type + conversion bindings (E5M2/E4M3/E8M0), HW-accel detection, and comprehensive tests (NVIDIA#686)
- fix: fix boolean return type mismatch in C ABI wrapper (NVIDIA#770)
- Remove unused `rtapi.py`  (NVIDIA#773)
- feat: Add documentation for debugging Numba CUDA programs with CUDA GDB and VSCode (NVIDIA#665)
- Move `CallConv` from `CUDAContext` to `FunctionDescriptor` (NVIDIA#717)
- Generate line info for PHI exporters in terminator block (NVIDIA#756)
- Add `cuda-core` to `oldest` tests (NVIDIA#769)
- build(deps): bump actions/setup-python from 6.1.0 to 6.2.0 in the actions-monthly group across 1 directory (NVIDIA#768)
- Enable apt proxy caching; skip hosted Windows builds (NVIDIA#766)
- Disable automatic review trigger for Greptile (NVIDIA#743)
- test(refactor): clean up `run_in_subprocess` (NVIDIA#762)
- remove super args (NVIDIA#763)
@gmarkall gmarkall mentioned this pull request Feb 5, 2026
kkraus14 pushed a commit that referenced this pull request Feb 5, 2026
- Add CUDA FP8 type + conversion bindings (E5M2/E4M3/E8M0), HW-accel
detection, and comprehensive tests (#686)
- fix: fix boolean return type mismatch in C ABI wrapper (#770)
- Remove unused `rtapi.py`  (#773)
- feat: Add documentation for debugging Numba CUDA programs with CUDA
GDB and VSCode (#665)
- Move `CallConv` from `CUDAContext` to `FunctionDescriptor` (#717)
- Generate line info for PHI exporters in terminator block (#756)
- Add `cuda-core` to `oldest` tests (#769)
- build(deps): bump actions/setup-python from 6.1.0 to 6.2.0 in the
actions-monthly group across 1 directory (#768)
- Enable apt proxy caching; skip hosted Windows builds (#766)
- Disable automatic review trigger for Greptile (#743)
- test(refactor): clean up `run_in_subprocess` (#762)
- remove super args (#763)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants