test(refactor): clean up run_in_subprocess

[cpcloud]

Small PR to refactor run_in_subprocess to avoid explicit and overly verbose Popen use.

[cpcloud]

/ok to test

[copy-pr-bot]

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

[greptile-apps]

Greptile Overview

Greptile Summary

This PR successfully refactors run_in_subprocess to use the more modern subprocess.run API instead of the verbose Popen approach. The refactoring includes using text=True to automatically handle string encoding/decoding, eliminating the need for manual .decode() calls in test code.

Key changes:

• Replaced subprocess.Popen with subprocess.run in support.py:196-217
• Added text=True parameter to return strings instead of bytes
• Simplified error handling with CalledProcessError exception
• Updated test_warning.py:44 to remove .decode() call
• Modernized test_import.py:54-65 to work with string output using .splitlines()

The refactoring is clean and maintains backward compatibility with all existing callers of run_in_subprocess.

Confidence Score: 5/5

• This PR is safe to merge - it's a straightforward refactoring with no logic changes
• The refactoring is well-executed, all affected call sites have been updated correctly, and the change maintains the same behavior while simplifying the code
• No files require special attention

Important Files Changed

Filename	Overview
numba_cuda/numba/cuda/tests/support.py	Refactored run_in_subprocess to use subprocess.run with text=True, simplifying code and making it more Pythonic
numba_cuda/numba/cuda/tests/cudapy/test_warning.py	Removed .decode() call since run_in_subprocess now returns strings instead of bytes
numba_cuda/numba/cuda/tests/nocuda/test_import.py	Updated to use .splitlines() on string output and replaced assertion with simpler assert statement

[greptile-apps]

_{3 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[cpcloud]

/ok to test

[greptile-apps]

_{3 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

_{3 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

[cpcloud]

/ok to test