Skip to content

Conversation

@cpcloud
Copy link
Contributor

@cpcloud cpcloud commented Jan 12, 2026

Temporary workaround to get CI passing

@cpcloud
Copy link
Contributor Author

cpcloud commented Jan 12, 2026

/ok to test

@copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 12, 2026

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 12, 2026

Greptile Overview

Greptile Summary

This PR adds locked: false to all three GitHub Actions workflows that use the setup-pixi action, bypassing the pixi lockfile to work around pixi issue #5256.

What Changed:

  • .github/workflows/conda-python-tests.yaml: Added locked: false parameter
  • .github/workflows/docs-build.yaml: Added locked: false parameter
  • .github/workflows/simulator-test.yaml: Added locked: false parameter

Impact:
The change is applied consistently across all workflow files that use setup-pixi. By disabling the lockfile, CI will resolve dependencies dynamically instead of using the committed pixi.lock file. This is described as a temporary workaround to get CI passing.

Concerns:

  1. Lack of inline documentation: The workflow files don't include comments explaining this is temporary or linking to the upstream issue, which could lead to the workaround becoming permanent
  2. Reproducibility: Without the lockfile, different CI runs may resolve slightly different dependency versions, potentially causing inconsistent behavior between runs or between local development (which uses the lockfile by default) and CI
  3. Lockfile maintenance burden: The repository maintains an active lockfile (recent PRs ci: relock pixi #712, chore(deps): bump numba-cuda version and relock pixi #707, chore(deps): bump deps in pixi lockfile #693), but CI now ignores it

Recommendation:
Consider adding TODO comments in the workflow files to track when this workaround can be reverted once the upstream pixi issue is resolved.

Confidence Score: 4/5

  • This PR is safe to merge as a temporary workaround to unblock CI, but lacks inline documentation for future maintainability
  • The changes are minimal, consistent across all affected files, and address a specific CI blocking issue. The implementation is straightforward - simply adding locked: false to bypass the pixi lockfile. However, the score is not 5 because: (1) the temporary nature is only documented in the commit message, not in the workflow files themselves, which could lead to this workaround becoming permanent, and (2) disabling the lockfile introduces potential reproducibility concerns between CI runs and between CI and local development environments. These are maintainability and operational concerns rather than critical bugs, making this safe to merge while acknowledging the technical debt being introduced.
  • All three workflow files would benefit from inline TODO comments to ensure this temporary workaround is reverted once the upstream pixi issue is resolved

Important Files Changed

File Analysis

Filename Score Overview
.github/workflows/conda-python-tests.yaml 4/5 Added locked: false to setup-pixi action to bypass pixi issue #5256 - temporary workaround that may cause non-reproducible builds
.github/workflows/docs-build.yaml 4/5 Added locked: false to setup-pixi action to bypass pixi issue #5256 - temporary workaround that may cause non-reproducible builds
.github/workflows/simulator-test.yaml 4/5 Added locked: false to setup-pixi action to bypass pixi issue #5256 - temporary workaround that may cause non-reproducible builds

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, 3 comments

Edit Code Review Agent Settings | Greptile

@cpcloud cpcloud enabled auto-merge (squash) January 12, 2026 14:49
@cpcloud cpcloud merged commit 6f85544 into NVIDIA:main Jan 12, 2026
89 checks passed
@cpcloud cpcloud deleted the disable-pixi-locked branch January 12, 2026 18:01
gmarkall added a commit to gmarkall/numba-cuda that referenced this pull request Jan 12, 2026
- Add arch specific target support (NVIDIA#549)
- chore: disable `locked` flag to bypass prefix-dev/pixi#5256 (NVIDIA#714)
- ci: relock pixi (NVIDIA#712)
- ci: remove redundant conda build in ci (NVIDIA#711)
- chore(deps): bump numba-cuda version and relock pixi (NVIDIA#707)
- Dropping bits in the old CI & Propagating recent changes from cuda-python (NVIDIA#683)
- Fix `test_wheel_deps_wheels.sh` to actually uninstall `nvvm` and `nvrtc` packages for CUDA 13 (NVIDIA#701)
- perf: remove some exception control flow and buffer-exception penalization for arrays (NVIDIA#700)
- perf: let CAI fall through instead of calling from_cuda_array_interface (NVIDIA#694)
- chore: perf lint (NVIDIA#697)
- chore(deps): bump deps in pixi lockfile (NVIDIA#693)
- fix: use freethreading-supported `_PySet_NextItemRef` where possible (NVIDIA#682)
- Support python `3.14` (NVIDIA#599)
- Remove customized address space tracking and address class emission in debug info (NVIDIA#669)
- Drop `experimental` from cuda.core namespace imports (NVIDIA#676)
- Remove dangling references to NUMBA_CUDA_ENABLE_MINOR_VERSION_COMPATIBILITY (NVIDIA#675)
- Use `rapidsai/sccache` in CI (NVIDIA#674)
- chore(dev-deps): remove ipython and pyinstrument (NVIDIA#670)
- Set up a new VM-based CI infrastructure  (NVIDIA#604)
@gmarkall gmarkall mentioned this pull request Jan 12, 2026
gmarkall added a commit that referenced this pull request Jan 12, 2026
- Add arch specific target support (#549)
- chore: disable `locked` flag to bypass
prefix-dev/pixi#5256 (#714)
- ci: relock pixi (#712)
- ci: remove redundant conda build in ci (#711)
- chore(deps): bump numba-cuda version and relock pixi (#707)
- Dropping bits in the old CI & Propagating recent changes from
cuda-python (#683)
- Fix `test_wheel_deps_wheels.sh` to actually uninstall `nvvm` and
`nvrtc` packages for CUDA 13 (#701)
- perf: remove some exception control flow and buffer-exception
penalization for arrays (#700)
- perf: let CAI fall through instead of calling
from_cuda_array_interface (#694)
- chore: perf lint (#697)
- chore(deps): bump deps in pixi lockfile (#693)
- fix: use freethreading-supported `_PySet_NextItemRef` where possible
(#682)
- Support python `3.14` (#599)
- Remove customized address space tracking and address class emission in
debug info (#669)
- Drop `experimental` from cuda.core namespace imports (#676)
- Remove dangling references to
NUMBA_CUDA_ENABLE_MINOR_VERSION_COMPATIBILITY (#675)
- Use `rapidsai/sccache` in CI (#674)
- chore(dev-deps): remove ipython and pyinstrument (#670)
- Set up a new VM-based CI infrastructure  (#604)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants