Use `rapidsai/sccache` in CI #674

trxcllnt · 2025-12-18T04:15:23Z

Use the rapidsai/sccache fork in CI because it supports caching fatbins and ltoir.

Closes #673

copy-pr-bot · 2025-12-18T04:15:26Z

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

trxcllnt · 2025-12-18T04:16:10Z

/ok to test 2f01dd6

greptile-apps · 2025-12-18T04:17:57Z

Greptile Summary

This PR switches from Mozilla's sccache to the RAPIDS fork to enable caching for CUDA fatbin and ltoir compilation outputs. The changes properly configure the RAPIDS sccache binary installation, enable preprocessor cache mode for better caching, and update the Makefile to use sccache for previously excluded compilation targets (fatbin and ltoir). The environment variable configuration has been updated to use GHA cache backend instead of disk-based caching.

Replaces mozilla-actions/sccache-action with manual installation of rapidsai/sccache from latest release
Adds SCCACHE_GHA_USE_PREPROCESSOR_CACHE_MODE=true to enable preprocessor caching feature
Updates environment variable exports to include all required GHA cache variables with fallbacks
Enables sccache for fatbin and ltoir nvcc targets in Makefile (lines 65, 68, 80, 99, 102, 114)
Removes disk-based cache configuration in favor of GHA cache backend
Changes stats command to --show-adv-stats for more detailed cache statistics
Upgrades actions/github-script from v7 to v8

Confidence Score: 5/5

This PR is safe to merge with minimal risk
The changes are well-structured and address a specific issue (CI: Switch to use RAPIDSAI/sccache? #673) by switching to the RAPIDS sccache fork. The implementation correctly handles the binary installation, environment variable configuration, and Makefile updates. All changes align with the stated goal of enabling fatbin/ltoir caching support.
No files require special attention

Important Files Changed

Filename	Overview
.github/workflows/build-wheel.yml	Replaced `mozilla-actions/sccache-action` with manual installation of `rapidsai/sccache`, added preprocessor cache mode, updated env vars handling, and changed stats command to `--show-adv-stats`
testing/Makefile	Enabled sccache for fatbin and ltoir compilation targets, which were previously excluded due to upstream sccache limitations
ci/tools/env-vars	Removed disk-based cache configuration (`SCCACHE_DIR` and `SCCACHE_CACHE_SIZE`), switching to GHA cache backend

greptile-apps

Additional Comments (1)

testing/Makefile, line 34 (link)

style: Outdated comment - the RapidsAI fork now supports fatbin and ltoir

_{2 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

trxcllnt · 2025-12-18T04:24:44Z

/ok to test 3c9bde4

greptile-apps

Additional Comments (1)

testing/Makefile, line 34 (link)

syntax: outdated comment - rapidsai/sccache now supports fatbin and ltoir

_{2 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

trxcllnt · 2025-12-18T04:33:00Z

/ok to test 24a7700

greptile-apps

Additional Comments (2)

.github/workflows/build-wheel.yml, line 50 (link)

style: using /releases/latest/ could lead to unexpected behavior if the latest release introduces breaking changes
.github/workflows/build-wheel.yml, line 102-110 (link)

style: removed SCCACHE_DIR and SCCACHE_CACHE_SIZE env vars from the cibuildwheel environment

The ci/tools/env-vars script still sets these in GITHUB_ENV (lines 40-41), but they're no longer passed to the cibuildwheel container. Verify sccache will use defaults or if these need to be passed through.

_{2 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

trxcllnt · 2025-12-18T05:10:51Z

/ok to test e7d29c0

trxcllnt · 2025-12-18T05:33:41Z

/ok to test b1760f2

trxcllnt · 2025-12-18T06:05:49Z

/ok to test e5e6799

greptile-apps

Additional Comments (2)

.github/workflows/build-wheel.yml, line 50-51 (link)

syntax: Remove the second -x flag before the wildcard pattern. The -x is already specified in -xvzf, and the second one is invalid syntax.
.github/workflows/build-wheel.yml, line 166-167 (link)

syntax: Same issue: remove the second -x flag before the wildcard pattern.

_{3 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

trxcllnt · 2025-12-18T06:22:21Z

/ok to test 95962f5

trxcllnt · 2025-12-18T06:36:07Z

/ok to test d74dc10

cpcloud

LGTM

- Add arch specific target support (NVIDIA#549) - chore: disable `locked` flag to bypass prefix-dev/pixi#5256 (NVIDIA#714) - ci: relock pixi (NVIDIA#712) - ci: remove redundant conda build in ci (NVIDIA#711) - chore(deps): bump numba-cuda version and relock pixi (NVIDIA#707) - Dropping bits in the old CI & Propagating recent changes from cuda-python (NVIDIA#683) - Fix `test_wheel_deps_wheels.sh` to actually uninstall `nvvm` and `nvrtc` packages for CUDA 13 (NVIDIA#701) - perf: remove some exception control flow and buffer-exception penalization for arrays (NVIDIA#700) - perf: let CAI fall through instead of calling from_cuda_array_interface (NVIDIA#694) - chore: perf lint (NVIDIA#697) - chore(deps): bump deps in pixi lockfile (NVIDIA#693) - fix: use freethreading-supported `_PySet_NextItemRef` where possible (NVIDIA#682) - Support python `3.14` (NVIDIA#599) - Remove customized address space tracking and address class emission in debug info (NVIDIA#669) - Drop `experimental` from cuda.core namespace imports (NVIDIA#676) - Remove dangling references to NUMBA_CUDA_ENABLE_MINOR_VERSION_COMPATIBILITY (NVIDIA#675) - Use `rapidsai/sccache` in CI (NVIDIA#674) - chore(dev-deps): remove ipython and pyinstrument (NVIDIA#670) - Set up a new VM-based CI infrastructure (NVIDIA#604)

- Add arch specific target support (#549) - chore: disable `locked` flag to bypass prefix-dev/pixi#5256 (#714) - ci: relock pixi (#712) - ci: remove redundant conda build in ci (#711) - chore(deps): bump numba-cuda version and relock pixi (#707) - Dropping bits in the old CI & Propagating recent changes from cuda-python (#683) - Fix `test_wheel_deps_wheels.sh` to actually uninstall `nvvm` and `nvrtc` packages for CUDA 13 (#701) - perf: remove some exception control flow and buffer-exception penalization for arrays (#700) - perf: let CAI fall through instead of calling from_cuda_array_interface (#694) - chore: perf lint (#697) - chore(deps): bump deps in pixi lockfile (#693) - fix: use freethreading-supported `_PySet_NextItemRef` where possible (#682) - Support python `3.14` (#599) - Remove customized address space tracking and address class emission in debug info (#669) - Drop `experimental` from cuda.core namespace imports (#676) - Remove dangling references to NUMBA_CUDA_ENABLE_MINOR_VERSION_COMPATIBILITY (#675) - Use `rapidsai/sccache` in CI (#674) - chore(dev-deps): remove ipython and pyinstrument (#670) - Set up a new VM-based CI infrastructure (#604)

trxcllnt added 2 commits December 17, 2025 20:14

install rapidsai/sccache in CI

8fdcb61

use sccache in fatbin and ltoir makefile targets

2f01dd6

greptile-apps bot reviewed Dec 18, 2025

View reviewed changes

print advanced sccache stats

3c9bde4

greptile-apps bot reviewed Dec 18, 2025

View reviewed changes

trxcllnt added 3 commits December 17, 2025 20:30

update comment

5875676

only show stats on Linux

df53e66

don't use disk cache

24a7700

greptile-apps bot reviewed Dec 18, 2025

View reviewed changes

enable caching in build-tests job

e7d29c0

remove unused SCCACHE_DIR

b1760f2

enable and store preprocessor cache in GHA cache

e5e6799

trxcllnt force-pushed the fea/use-rapidsai-sccache branch from aaf40ba to e5e6799 Compare December 18, 2025 06:05

greptile-apps bot reviewed Dec 18, 2025

View reviewed changes

remove SCCACHE_GHA_PREPROCESSOR_CACHE_KEY_PREFIX

d74dc10

trxcllnt force-pushed the fea/use-rapidsai-sccache branch from 95962f5 to d74dc10 Compare December 18, 2025 06:35

gmarkall added the 3 - Ready for Review Ready for review by team label Dec 18, 2025

cpcloud approved these changes Dec 18, 2025

View reviewed changes

cpcloud merged commit a66695c into NVIDIA:main Dec 18, 2025
121 checks passed

trxcllnt deleted the fea/use-rapidsai-sccache branch December 18, 2025 15:41

gmarkall mentioned this pull request Jan 12, 2026

Bump version to 0.24.0 #716

Merged

Use rapidsai/sccache in CI #674

Use rapidsai/sccache in CI #674

Uh oh!

Conversation

trxcllnt commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

copy-pr-bot bot commented Dec 18, 2025

Uh oh!

trxcllnt commented Dec 18, 2025

Uh oh!

greptile-apps bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

greptile-apps bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Additional Comments (1)

Uh oh!

trxcllnt commented Dec 18, 2025

Uh oh!

greptile-apps bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Additional Comments (1)

Uh oh!

trxcllnt commented Dec 18, 2025

Uh oh!

greptile-apps bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Additional Comments (2)

Uh oh!

trxcllnt commented Dec 18, 2025

Uh oh!

trxcllnt commented Dec 18, 2025

Uh oh!

trxcllnt commented Dec 18, 2025

Uh oh!

greptile-apps bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Additional Comments (2)

Uh oh!

trxcllnt commented Dec 18, 2025

Uh oh!

trxcllnt commented Dec 18, 2025

Uh oh!

cpcloud left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Use `rapidsai/sccache` in CI #674

Use `rapidsai/sccache` in CI #674

trxcllnt commented Dec 18, 2025 •

edited

Loading

greptile-apps bot commented Dec 18, 2025 •

edited

Loading

greptile-apps bot left a comment •

edited

Loading

greptile-apps bot left a comment •

edited

Loading

greptile-apps bot left a comment •

edited

Loading

greptile-apps bot left a comment •

edited

Loading