-
Notifications
You must be signed in to change notification settings - Fork 54
Attempt to fix Awkward Array 3rd party tests #607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8e2bea9
Attempt to fix Awkward Array 3rd party tests
gmarkall 5d48f61
Patch out test generation for intermittently-failling Awkward test
gmarkall 17971de
Patch another test out and unpin CuPy
gmarkall 03c03c2
Remove cuda-core pinning from other test files
gmarkall 2a82feb
Document awkward test suite patches
gmarkall 8916637
Skip another intermittent test
gmarkall File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,7 +17,7 @@ echo "Package path: ${package}" | |
| python -m pip install \ | ||
| "${package}" \ | ||
| "cuda-python==${CUDA_VER_MAJOR_MINOR%.*}.*" \ | ||
| "cuda-core==0.3.*" \ | ||
| "cuda-core" \ | ||
| "nvidia-nvjitlink-cu12" \ | ||
| --group test | ||
|
|
||
|
|
@@ -27,6 +27,55 @@ git clone --recursive https://github.com/scikit-hep/awkward.git | |
| pushd awkward | ||
| git checkout v${AWKWARD_VERSION} | ||
|
|
||
| # Avoid tests that are unreliable on the CUDA target: | ||
| # | ||
| # - awkward_RecordArray_reduce_nonlocal_outoffsets_64 | ||
| # - test_3459_virtualarray_with_cuda | ||
| # | ||
| # as per discussion in https://github.com/scikit-hep/awkward/discussions/3587 | ||
|
|
||
|
|
||
| rapids-logger "Patch awkward tests" | ||
|
|
||
| patch -p1 <<'EOF' | ||
| diff --git a/dev/generate-tests.py b/dev/generate-tests.py | ||
| index 1292e0cf..4534a57c 100644 | ||
| --- a/dev/generate-tests.py | ||
| +++ b/dev/generate-tests.py | ||
| @@ -970,7 +970,6 @@ cuda_kernels_tests = [ | ||
| "awkward_UnionArray_regular_index_getsize", | ||
| "awkward_UnionArray_simplify", | ||
| "awkward_UnionArray_simplify_one", | ||
| - "awkward_RecordArray_reduce_nonlocal_outoffsets_64", | ||
| "awkward_reduce_count_64", | ||
| "awkward_reduce_max", | ||
| "awkward_reduce_max_complex", | ||
| diff --git a/tests-cuda/test_3459_virtualarray_with_cuda.py b/tests-cuda/test_3459_virtualarray_with_cuda.py | ||
| index e2bcab12..c82f63c3 100644 | ||
| --- a/tests-cuda/test_3459_virtualarray_with_cuda.py | ||
| +++ b/tests-cuda/test_3459_virtualarray_with_cuda.py | ||
| @@ -9,6 +9,7 @@ import awkward as ak | ||
| from awkward._nplikes.cupy import Cupy | ||
| from awkward._nplikes.virtual import VirtualNDArray | ||
|
|
||
| +pytestmark = pytest.mark.skip("temporarily skipping all tests in this module") | ||
|
|
||
| @pytest.fixture(scope="function", autouse=True) | ||
| def cleanup_cuda(): | ||
| diff --git a/tests-cuda/test_3149_complex_reducers.py b/tests-cuda/test_3149_complex_reducers.py | ||
| index 39080a34..0eb3940f 100644 | ||
| --- a/tests-cuda/test_3149_complex_reducers.py | ||
| +++ b/tests-cuda/test_3149_complex_reducers.py | ||
| @@ -544,6 +544,7 @@ def test_block_boundary_prod_complex12(): | ||
| del cuda_content, cuda_depth1 | ||
|
|
||
|
|
||
| [email protected]("Intermittent failures") | ||
| def test_block_boundary_prod_complex13(): | ||
| rng = np.random.default_rng(seed=42) | ||
| array = rng.integers(50, size=1000) | ||
| EOF | ||
|
|
||
| rapids-logger "Generate awkward tests" | ||
| nox -s prepare -- --tests | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.