Skip to content

Conversation

@gmarkall
Copy link
Contributor

@gmarkall gmarkall commented Nov 24, 2025

A couple of Awkward Array tests cover functionality that is experimental and/or unused in CUDA, as discussed in scikit-hep/awkward#3587.

These tests can fail intermittently, causing issues for CI. This PR patches out the generation and execution of these tests.

We should also not be constraining the version of cuda-core that is installed alongside numba-cuda. The Awkward Array CI test script did this, but so did the other thirdparty tests and the coverage test. This pinning is now removed.

CuPy 13.6 seems to cause some issues in the Awkward test suite -
switching back to 13.4.

We should also not be constraining the version of cuda-core that is
installed alongside numba-cuda.
@copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 24, 2025

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@gmarkall
Copy link
Contributor Author

/ok to test

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 24, 2025

Greptile Overview

Greptile Summary

Removed cuda-core==0.3.* version constraint from all CI test scripts, allowing numba-cuda to work with any compatible cuda-core version. Added a patch to the Awkward Array test script to skip three tests that fail intermittently due to experimental/unused CUDA functionality:

  • Removed awkward_RecordArray_reduce_nonlocal_outoffsets_64 from test generation
  • Skipped entire test_3459_virtualarray_with_cuda module
  • Skipped test_block_boundary_prod_complex13 function

The patch is well-documented with references to the upstream discussion (scikit-hep/awkward#3587) and uses correct heredoc syntax to ensure the patch content is applied literally.

Confidence Score: 5/5

  • Safe to merge - simple, well-documented changes that address intermittent test failures
  • Changes are straightforward and low-risk: removing overly-restrictive version constraints allows proper dependency resolution, and patching out problematic tests prevents intermittent CI failures without affecting actual functionality. The patch uses correct bash heredoc syntax and is properly documented.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
ci/test_thirdparty_awkward.sh 5/5 Removed cuda-core version pinning and added patch to skip three intermittent Awkward Array tests
ci/coverage_report.sh 5/5 Removed cuda-core==0.3.* version constraint, now allows any cuda-core version
ci/test_thirdparty_cudf.sh 5/5 Removed cuda-core==0.3.* version constraint, now allows any cuda-core version
ci/test_thirdparty_nvmath.sh 5/5 Removed cuda-core==0.3.* version constraint, now allows any cuda-core version

Sequence Diagram

sequenceDiagram
    participant CI as CI Pipeline
    participant PIP as pip install
    participant GIT as Git Clone
    participant PATCH as Patch Application
    participant NOX as Nox Test Gen
    participant PYTEST as Pytest Runner
    
    Note over CI: All Test Scripts
    CI->>PIP: Install numba-cuda wheel
    PIP->>PIP: Install cuda-python (versioned)
    PIP->>PIP: Install cuda-core (any version)
    Note right of PIP: Removed 0.3.* constraint
    
    Note over CI: Awkward Array Tests Only
    CI->>GIT: Clone awkward repo v2.8.10
    CI->>PATCH: Apply test exclusion patch
    PATCH->>PATCH: Remove awkward_RecordArray_reduce_nonlocal_outoffsets_64 from generation
    PATCH->>PATCH: Skip test_3459_virtualarray_with_cuda module
    PATCH->>PATCH: Skip test_block_boundary_prod_complex13
    Note right of PATCH: Avoids intermittent failures
    CI->>NOX: Generate tests (nox -s prepare)
    CI->>PYTEST: Run CUDA tests
    PYTEST-->>CI: Test results
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@gmarkall
Copy link
Contributor Author

/ok to test

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

The CuPy version seems not to have necessarily been related to the pass
/ fail outcomes.
@gmarkall
Copy link
Contributor Author

/ok to test

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@gmarkall gmarkall added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Nov 25, 2025
@gmarkall
Copy link
Contributor Author

/ok to test

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@gmarkall
Copy link
Contributor Author

/ok to test

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@gmarkall
Copy link
Contributor Author

/ok to test

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@gmarkall gmarkall added 4 - Waiting on CI Waiting for a CI run to finish successfully 3 - Ready for Review Ready for review by team and removed 3 - Ready for Review Ready for review by team 4 - Waiting on CI Waiting for a CI run to finish successfully labels Nov 25, 2025
@rparolin rparolin self-requested a review November 25, 2025 22:42
@gmarkall gmarkall merged commit 5b83122 into NVIDIA:main Nov 25, 2025
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 - Ready for Review Ready for review by team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants