-
Notifications
You must be signed in to change notification settings - Fork 54
Attempt to fix Awkward Array 3rd party tests #607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CuPy 13.6 seems to cause some issues in the Awkward test suite - switching back to 13.4. We should also not be constraining the version of cuda-core that is installed alongside numba-cuda.
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
Greptile OverviewGreptile SummaryRemoved
The patch is well-documented with references to the upstream discussion (scikit-hep/awkward#3587) and uses correct heredoc syntax to ensure the patch content is applied literally. Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant CI as CI Pipeline
participant PIP as pip install
participant GIT as Git Clone
participant PATCH as Patch Application
participant NOX as Nox Test Gen
participant PYTEST as Pytest Runner
Note over CI: All Test Scripts
CI->>PIP: Install numba-cuda wheel
PIP->>PIP: Install cuda-python (versioned)
PIP->>PIP: Install cuda-core (any version)
Note right of PIP: Removed 0.3.* constraint
Note over CI: Awkward Array Tests Only
CI->>GIT: Clone awkward repo v2.8.10
CI->>PATCH: Apply test exclusion patch
PATCH->>PATCH: Remove awkward_RecordArray_reduce_nonlocal_outoffsets_64 from generation
PATCH->>PATCH: Skip test_3459_virtualarray_with_cuda module
PATCH->>PATCH: Skip test_block_boundary_prod_complex13
Note right of PATCH: Avoids intermittent failures
CI->>NOX: Generate tests (nox -s prepare)
CI->>PYTEST: Run CUDA tests
PYTEST-->>CI: Test results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 1 comment
|
/ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, no comments
The CuPy version seems not to have necessarily been related to the pass / fail outcomes.
|
/ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, no comments
|
/ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 files reviewed, no comments
|
/ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 files reviewed, no comments
|
/ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 files reviewed, no comments
A couple of Awkward Array tests cover functionality that is experimental and/or unused in CUDA, as discussed in scikit-hep/awkward#3587.
These tests can fail intermittently, causing issues for CI. This PR patches out the generation and execution of these tests.
We should also not be constraining the version of cuda-core that is installed alongside numba-cuda. The Awkward Array CI test script did this, but so did the other thirdparty tests and the coverage test. This pinning is now removed.