cuopt-numerical-optimization-formulation: catalog onboarding prep - #1345
Conversation
Shorten the SKILL.md description to fit the 50-150 char range the NV-BASE quality scorer recommends. The previous CI run reported "Description very long" (NVIDIA Agent Skills Publishing Onboarding Guide § "Writing Skills for Good Agent Triggering"). No behavior change; documentation/metadata only. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
Aligns with the NVIDIA Agent Skills Publishing Onboarding Guide: * Add top-level SECURITY.md so the catalog's "Getting Help & Contributing" links resolve once this repo is registered in components.d/<slug>.yml (guide §"Recommended Repository Layout"). * Wire .github/CODEOWNERS and .github/workflows/pr.yaml so doc-only edits to SECURITY.md don't trigger the full CI matrix (cpp-build, python-build, docs-build, conda-build path-filter blocks). * Shorten cuopt-skill-evolution SKILL.md description to fit the 50-150 char range the NV-BASE quality scorer recommends. The previous CI run reported "Description very long" (guide §"Writing Skills for Good Agent Triggering"). Per-skill description and PII-array changes for the other skills moved to dedicated follow-up PRs (#1343, #1344, #1345, #1346) so each PR's CI scope is limited to one skill. No behavior change; documentation/metadata only. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
📝 WalkthroughWalkthroughEdits shorten and clarify the skill’s top-level description and skill-card text to state “concepts only; no API”, update BENCHMARK.md evaluation date, signals, per-agent scores and validation summaries, and replace the sigstore DSSE signature bundle to match the updated payload. ChangesSkill content & evaluation updates
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/cuopt-numerical-optimization-formulation/SKILL.md`:
- Line 4: This PR modifies content under skills/ (SKILL.md) but did not trigger
the NVSkills CI gate; to fix, post the NVSkills validation request by adding a
PR comment that contains the exact trigger "/nvskills-ci", then verify the
NVSkills signature commit is still present in the PR history (ensure the
signature commit hash shown by NVSkills remains in the branch) before merging;
reference the changed resource SKILL.md when posting the comment and confirm the
signature commit is not removed by any rebases or squashes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 85c7d7f8-1827-4cdd-8391-26362d566800
📒 Files selected for processing (1)
skills/cuopt-numerical-optimization-formulation/SKILL.md
| name: cuopt-numerical-optimization-formulation | ||
| version: "26.08.00" | ||
| description: Numerical optimization (LP, MILP, QP) — concepts, problem-text parsing, and formulation patterns. What LP, MILP, and QP are, required formulation questions, modeling elements, common patterns, and how to parse problem statements (parameters, constraints, decisions, objective). Domain concepts; no API or interface. | ||
| description: LP, MILP, QP — concepts, problem-text parsing, and formulation patterns (parameters, constraints, decisions, objective). Concepts only; no API. |
There was a problem hiding this comment.
Please complete the required skills/ CI gate for this PR.
For changes under skills/**/*, request NVSkills validation by commenting /nvskills-ci on the PR and confirm the signature commit is still present before merge.
As per coding guidelines, "skills/**/*: For PRs changing content under skills/ directory, request NVSkills CI validation by commenting /nvskills-ci and ensure the signature commit remains in the PR".
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@skills/cuopt-numerical-optimization-formulation/SKILL.md` at line 4, This PR
modifies content under skills/ (SKILL.md) but did not trigger the NVSkills CI
gate; to fix, post the NVSkills validation request by adding a PR comment that
contains the exact trigger "/nvskills-ci", then verify the NVSkills signature
commit is still present in the PR history (ensure the signature commit hash
shown by NVSkills remains in the branch) before merging; reference the changed
resource SKILL.md when posting the comment and confirm the signature commit is
not removed by any rebases or squashes.
|
/nvskills-ci |
Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/cuopt-numerical-optimization-formulation/BENCHMARK.md`:
- Line 61: The table cell currently displays "93% (-0%)" — normalize any
negative-zero uplift so it renders as "0%" instead of "-0%": update the uplift
formatting logic (the routine that produces the "93% (±X%)" display, e.g., your
uplift formatter/renderer that emits the "(-0%)" token) to treat values whose
absolute value is effectively zero (e.g., Math.abs(value) < epsilon or value ===
0 after rounding) as 0 and format them without a negative sign; ensure the sign
is only shown for nonzero uplifts and update the generated markdown so "93%
(-0%)" becomes "93% (0%)".
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 36ed6ac3-64e8-4edc-99e1-bc6f2d97fbb7
📒 Files selected for processing (3)
skills/cuopt-numerical-optimization-formulation/BENCHMARK.mdskills/cuopt-numerical-optimization-formulation/skill-card.mdskills/cuopt-numerical-optimization-formulation/skill.oms.sig
✅ Files skipped from review due to trivial changes (1)
- skills/cuopt-numerical-optimization-formulation/skill-card.md
| | Correctness | 2 | 100% (+0%) | 97% (+28%) | | ||
| | Discoverability | 2 | 100% (+0%) | 97% (+66%) | | ||
| | Effectiveness | 2 | 96% (+0%) | 90% (-5%) | | ||
| | Efficiency | 2 | 93% (-0%) | 96% (+51%) | |
There was a problem hiding this comment.
Normalize uplift display to 0% instead of -0%.
93% (-0%) is a confusing presentation artifact; please render zero uplift as 0% for consistency/readability.
Suggested fix
-| Efficiency | 2 | 93% (-0%) | 96% (+51%) |
+| Efficiency | 2 | 93% (0%) | 96% (+51%) |📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| | Efficiency | 2 | 93% (-0%) | 96% (+51%) | | |
| | Efficiency | 2 | 93% (0%) | 96% (+51%) | |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@skills/cuopt-numerical-optimization-formulation/BENCHMARK.md` at line 61, The
table cell currently displays "93% (-0%)" — normalize any negative-zero uplift
so it renders as "0%" instead of "-0%": update the uplift formatting logic (the
routine that produces the "93% (±X%)" display, e.g., your uplift
formatter/renderer that emits the "(-0%)" token) to treat values whose absolute
value is effectively zero (e.g., Math.abs(value) < epsilon or value === 0 after
rounding) as 0 and format them without a negative sign; ensure the sign is only
shown for nonzero uplifts and update the generated markdown so "93% (-0%)"
becomes "93% (0%)".
Summary
Shorten the SKILL.md description to fit the 50-150 char range the NV-BASE quality scorer recommends — the previous CI run reported "Description very long" (NVIDIA Agent Skills Publishing Onboarding Guide § "Writing Skills for Good Agent Triggering").