Skip to content

cuopt-numerical-optimization-formulation: catalog onboarding prep - #1345

Merged
ramakrishnap-nv merged 2 commits into
mainfrom
skills/onboarding-cuopt-numerical-optimization-formulation
May 29, 2026
Merged

cuopt-numerical-optimization-formulation: catalog onboarding prep#1345
ramakrishnap-nv merged 2 commits into
mainfrom
skills/onboarding-cuopt-numerical-optimization-formulation

Conversation

@ramakrishnap-nv

@ramakrishnap-nv ramakrishnap-nv commented May 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

Shorten the SKILL.md description to fit the 50-150 char range the NV-BASE quality scorer recommends — the previous CI run reported "Description very long" (NVIDIA Agent Skills Publishing Onboarding Guide § "Writing Skills for Good Agent Triggering").

Shorten the SKILL.md description to fit the 50-150 char range the
NV-BASE quality scorer recommends. The previous CI run reported
"Description very long" (NVIDIA Agent Skills Publishing Onboarding
Guide § "Writing Skills for Good Agent Triggering").

No behavior change; documentation/metadata only.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
@ramakrishnap-nv
ramakrishnap-nv requested a review from a team as a code owner May 29, 2026 15:44
@ramakrishnap-nv
ramakrishnap-nv requested a review from tmckayus May 29, 2026 15:44
ramakrishnap-nv added a commit that referenced this pull request May 29, 2026
Aligns with the NVIDIA Agent Skills Publishing Onboarding Guide:

* Add top-level SECURITY.md so the catalog's "Getting Help &
  Contributing" links resolve once this repo is registered in
  components.d/<slug>.yml (guide §"Recommended Repository Layout").

* Wire .github/CODEOWNERS and .github/workflows/pr.yaml so doc-only
  edits to SECURITY.md don't trigger the full CI matrix (cpp-build,
  python-build, docs-build, conda-build path-filter blocks).

* Shorten cuopt-skill-evolution SKILL.md description to fit the
  50-150 char range the NV-BASE quality scorer recommends. The
  previous CI run reported "Description very long" (guide §"Writing
  Skills for Good Agent Triggering").

Per-skill description and PII-array changes for the other skills
moved to dedicated follow-up PRs (#1343, #1344, #1345, #1346) so
each PR's CI scope is limited to one skill.

No behavior change; documentation/metadata only.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
@coderabbitai

coderabbitai Bot commented May 29, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Edits shorten and clarify the skill’s top-level description and skill-card text to state “concepts only; no API”, update BENCHMARK.md evaluation date, signals, per-agent scores and validation summaries, and replace the sigstore DSSE signature bundle to match the updated payload.

Changes

Skill content & evaluation updates

Layer / File(s) Summary
Skill description and card text
skills/cuopt-numerical-optimization-formulation/SKILL.md, skills/cuopt-numerical-optimization-formulation/skill-card.md
Shorten and retarget the LP/MILP/QP description to emphasize concepts only (no API); reword use case and restructure evaluation metadata and underlying signals (add security).
Benchmark and evaluation report
skills/cuopt-numerical-optimization-formulation/BENCHMARK.md
Update evaluation date to 2026-05-29, add security signal entry, revise per-agent scores/uplifts, and adjust Tier 1 static validation and Tier 2 deduplication parsed description length.
Sigstore signature bundle
skills/cuopt-numerical-optimization-formulation/skill.oms.sig
Replace DSSE signature bundle JSON: updated payload subject digest, predicate serialization ignore patterns/resources, and new embedded DSSE signature value.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • NVIDIA/cuopt#1287: Both PRs modify the same skills/cuopt-numerical-optimization-formulation artifacts—SKILL.md, skill-card.md, BENCHMARK.md/eval-related reporting, and regenerate skill.oms.sig payload/signature—so the changes are directly connected.
  • NVIDIA/cuopt#1328: The main PR refines documentation/content for the same cuopt-numerical-optimization-formulation skill (e.g., SKILL.md/skill-card.md wording and evaluation materials), which directly overlaps with the retrieved PR’s renaming of that skill’s metadata and directory—so they are related.

Suggested labels

non-breaking, improvement

Suggested reviewers

  • tmckayus
  • Iroy30
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'cuopt-numerical-optimization-formulation: catalog onboarding prep' is directly related to the changeset, which focuses on preparing the skill for catalog onboarding by shortening the SKILL.md description to meet quality scorer requirements.
Description check ✅ Passed The description clearly explains the motivation for changes (meeting 50-150 char recommendation) and references the relevant guidelines, directly relating to the documentation updates in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch skills/onboarding-cuopt-numerical-optimization-formulation

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@skills/cuopt-numerical-optimization-formulation/SKILL.md`:
- Line 4: This PR modifies content under skills/ (SKILL.md) but did not trigger
the NVSkills CI gate; to fix, post the NVSkills validation request by adding a
PR comment that contains the exact trigger "/nvskills-ci", then verify the
NVSkills signature commit is still present in the PR history (ensure the
signature commit hash shown by NVSkills remains in the branch) before merging;
reference the changed resource SKILL.md when posting the comment and confirm the
signature commit is not removed by any rebases or squashes.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 85c7d7f8-1827-4cdd-8391-26362d566800

📥 Commits

Reviewing files that changed from the base of the PR and between ea7acf0 and daf5495.

📒 Files selected for processing (1)
  • skills/cuopt-numerical-optimization-formulation/SKILL.md

name: cuopt-numerical-optimization-formulation
version: "26.08.00"
description: Numerical optimization (LP, MILP, QP) — concepts, problem-text parsing, and formulation patterns. What LP, MILP, and QP are, required formulation questions, modeling elements, common patterns, and how to parse problem statements (parameters, constraints, decisions, objective). Domain concepts; no API or interface.
description: LP, MILP, QP — concepts, problem-text parsing, and formulation patterns (parameters, constraints, decisions, objective). Concepts only; no API.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Please complete the required skills/ CI gate for this PR.

For changes under skills/**/*, request NVSkills validation by commenting /nvskills-ci on the PR and confirm the signature commit is still present before merge.

As per coding guidelines, "skills/**/*: For PRs changing content under skills/ directory, request NVSkills CI validation by commenting /nvskills-ci and ensure the signature commit remains in the PR".

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@skills/cuopt-numerical-optimization-formulation/SKILL.md` at line 4, This PR
modifies content under skills/ (SKILL.md) but did not trigger the NVSkills CI
gate; to fix, post the NVSkills validation request by adding a PR comment that
contains the exact trigger "/nvskills-ci", then verify the NVSkills signature
commit is still present in the PR history (ensure the signature commit hash
shown by NVSkills remains in the branch) before merging; reference the changed
resource SKILL.md when posting the comment and confirm the signature commit is
not removed by any rebases or squashes.

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented May 29, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@skills/cuopt-numerical-optimization-formulation/BENCHMARK.md`:
- Line 61: The table cell currently displays "93% (-0%)" — normalize any
negative-zero uplift so it renders as "0%" instead of "-0%": update the uplift
formatting logic (the routine that produces the "93% (±X%)" display, e.g., your
uplift formatter/renderer that emits the "(-0%)" token) to treat values whose
absolute value is effectively zero (e.g., Math.abs(value) < epsilon or value ===
0 after rounding) as 0 and format them without a negative sign; ensure the sign
is only shown for nonzero uplifts and update the generated markdown so "93%
(-0%)" becomes "93% (0%)".
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 36ed6ac3-64e8-4edc-99e1-bc6f2d97fbb7

📥 Commits

Reviewing files that changed from the base of the PR and between daf5495 and 7b3bc4a.

📒 Files selected for processing (3)
  • skills/cuopt-numerical-optimization-formulation/BENCHMARK.md
  • skills/cuopt-numerical-optimization-formulation/skill-card.md
  • skills/cuopt-numerical-optimization-formulation/skill.oms.sig
✅ Files skipped from review due to trivial changes (1)
  • skills/cuopt-numerical-optimization-formulation/skill-card.md

| Correctness | 2 | 100% (+0%) | 97% (+28%) |
| Discoverability | 2 | 100% (+0%) | 97% (+66%) |
| Effectiveness | 2 | 96% (+0%) | 90% (-5%) |
| Efficiency | 2 | 93% (-0%) | 96% (+51%) |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Normalize uplift display to 0% instead of -0%.

93% (-0%) is a confusing presentation artifact; please render zero uplift as 0% for consistency/readability.

Suggested fix
-| Efficiency | 2 | 93% (-0%) | 96% (+51%) |
+| Efficiency | 2 | 93% (0%) | 96% (+51%) |
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
| Efficiency | 2 | 93% (-0%) | 96% (+51%) |
| Efficiency | 2 | 93% (0%) | 96% (+51%) |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@skills/cuopt-numerical-optimization-formulation/BENCHMARK.md` at line 61, The
table cell currently displays "93% (-0%)" — normalize any negative-zero uplift
so it renders as "0%" instead of "-0%": update the uplift formatting logic (the
routine that produces the "93% (±X%)" display, e.g., your uplift
formatter/renderer that emits the "(-0%)" token) to treat values whose absolute
value is effectively zero (e.g., Math.abs(value) < epsilon or value === 0 after
rounding) as 0 and format them without a negative sign; ensure the sign is only
shown for nonzero uplifts and update the generated markdown so "93% (-0%)"
becomes "93% (0%)".

@ramakrishnap-nv
ramakrishnap-nv merged commit bca1300 into main May 29, 2026
3 of 4 checks passed
@ramakrishnap-nv
ramakrishnap-nv deleted the skills/onboarding-cuopt-numerical-optimization-formulation branch July 9, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants