Rename numerical-optimization-formulation to cuopt-numerical-optimization-formulation - #1328
Conversation
…optimization-formulation Prefix the formulation skill with cuopt- to match the product-scoped naming convention used by the other cuOpt skills in the catalog. Updates the directory name, the marketplace.json entry (name + source), the AGENTS.md bullet, and the expected_skill field in the eval. No SKILL.md content changes beyond the in-file self-reference. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughRenames the numerical optimization formulation skill to ChangesSkill Identifier Rename
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/nvskills-ci |
Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
|
/ok to test 87faa24 |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/cuopt-numerical-optimization-formulation/skill-card.md`:
- Around line 59-68: The Evaluation Results table in skill-card.md is not
surrounded by blank lines which triggers markdownlint MD058; update the markdown
around the "## Evaluation Results" block so there is an empty line before the
table and an empty line after the closing table row (i.e., add a blank line
between the heading and the table and another blank line after the table before
the next "## Skill Version(s):" header) to satisfy MD058.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: a48cd046-e76e-4a35-a463-7b2c370eb312
📒 Files selected for processing (3)
skills/cuopt-numerical-optimization-formulation/BENCHMARK.mdskills/cuopt-numerical-optimization-formulation/skill-card.mdskills/cuopt-numerical-optimization-formulation/skill.oms.sig
| ## Evaluation Results: <br> | ||
| | Dimension | Num | `claude-code` | `codex` | | ||
| |---|---:|---:|---:| | ||
| | Security | 2 | 100% (+0%) | 100% (+0%) | | ||
| | Correctness | 2 | 100% (+0%) | 97% (+23%) | | ||
| | Discoverability | 2 | 100% (+0%) | 84% (+48%) | | ||
| | Effectiveness | 2 | 97% (-2%) | 98% (+0%) | | ||
| | Efficiency | 2 | 93% (-0%) | 78% (+34%) | | ||
| | Security | 2 | 100% (+0%) | 83% (+0%) | | ||
| | Correctness | 2 | 100% (+0%) | 97% (+47%) | | ||
| | Discoverability | 2 | 100% (+0%) | 84% (+84%) | | ||
| | Effectiveness | 2 | 96% (-3%) | 90% (+1%) | | ||
| | Efficiency | 2 | 93% (-0%) | 76% (+49%) | | ||
|
|
||
| ## Skill Version(s): <br> |
There was a problem hiding this comment.
Add blank lines around the evaluation results table.
markdownlint MD058 is triggered because the table is not surrounded by blank lines.
Suggested fix
## Evaluation Results: <br>
+
| Dimension | Num | `claude-code` | `codex` |
|---|---:|---:|---:|
| Security | 2 | 100% (+0%) | 83% (+0%) |
| Correctness | 2 | 100% (+0%) | 97% (+47%) |
| Discoverability | 2 | 100% (+0%) | 84% (+84%) |
| Effectiveness | 2 | 96% (-3%) | 90% (+1%) |
| Efficiency | 2 | 93% (-0%) | 76% (+49%) |
+
## Skill Version(s): <br>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ## Evaluation Results: <br> | |
| | Dimension | Num | `claude-code` | `codex` | | |
| |---|---:|---:|---:| | |
| | Security | 2 | 100% (+0%) | 100% (+0%) | | |
| | Correctness | 2 | 100% (+0%) | 97% (+23%) | | |
| | Discoverability | 2 | 100% (+0%) | 84% (+48%) | | |
| | Effectiveness | 2 | 97% (-2%) | 98% (+0%) | | |
| | Efficiency | 2 | 93% (-0%) | 78% (+34%) | | |
| | Security | 2 | 100% (+0%) | 83% (+0%) | | |
| | Correctness | 2 | 100% (+0%) | 97% (+47%) | | |
| | Discoverability | 2 | 100% (+0%) | 84% (+84%) | | |
| | Effectiveness | 2 | 96% (-3%) | 90% (+1%) | | |
| | Efficiency | 2 | 93% (-0%) | 76% (+49%) | | |
| ## Skill Version(s): <br> | |
| ## Evaluation Results: <br> | |
| | Dimension | Num | `claude-code` | `codex` | | |
| |---|---:|---:|---:| | |
| | Security | 2 | 100% (+0%) | 83% (+0%) | | |
| | Correctness | 2 | 100% (+0%) | 97% (+47%) | | |
| | Discoverability | 2 | 100% (+0%) | 84% (+84%) | | |
| | Effectiveness | 2 | 96% (-3%) | 90% (+1%) | | |
| | Efficiency | 2 | 93% (-0%) | 76% (+49%) | | |
| ## Skill Version(s): <br> |
🧰 Tools
🪛 markdownlint-cli2 (0.22.1)
[warning] 60-60: Tables should be surrounded by blank lines
(MD058, blanks-around-tables)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@skills/cuopt-numerical-optimization-formulation/skill-card.md` around lines
59 - 68, The Evaluation Results table in skill-card.md is not surrounded by
blank lines which triggers markdownlint MD058; update the markdown around the
"## Evaluation Results" block so there is an empty line before the table and an
empty line after the closing table row (i.e., add a blank line between the
heading and the table and another blank line after the table before the next "##
Skill Version(s):" header) to satisfy MD058.
Rename numerical-optimization-formulation to cuopt-numerical-optimization-formulation