skills/cuopt-routing-api-python: update with benchmark details - #1333
Merged
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
ramakrishnap-nv
force-pushed
the
skills-cuopt-routing-api-python
branch
from
May 29, 2026 01:17
e2998a1 to
2c0c193
Compare
ramakrishnap-nv
marked this pull request as ready for review
May 29, 2026 01:17
Collaborator
Author
|
/nvskills-ci |
ramakrishnap-nv
added
non-breaking
📝 WalkthroughWalkthroughUpdates the cuopt-routing-api-python skill: reformats skill-card metadata, adds a BENCHMARK.md evaluation report (VERDICT: FAIL), inserts a blank line in SKILL.md frontmatter, and regenerates the Sigstore DSSE signature bundle reflecting new digests. Changescuopt-routing-api-python documentation & attestation
🎯 3 (Moderate) | ⏱️ ~20 minutes
Suggested reviewers:
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/cuopt-routing-api-python/BENCHMARK.md`:
- Line 72: Update the truncated security finding text in BENCHMARK.md by
replacing the truncated word "reac" with the full word "reach" in the MEDIUM
SECURITY/Unknown (SQP-2) entry so the sentence reads "...making it accessible to
any host that can reach (references/server_examples.md:7)". Ensure no other
words were accidentally altered and run a quick spellcheck on that line.
In `@skills/cuopt-routing-api-python/skill-card.md`:
- Around line 63-70: Add a single blank line after the evaluation results
Markdown table (the table starting with "| Dimension | Num | `claude-code` |
`codex` |") so there is an empty line separating the table from the following
section heading; update the skill-card.md content immediately after that table
to insert one newline before the next heading or paragraph.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 358fec5a-5730-495f-a4fc-cc410a6e4c7d
📒 Files selected for processing (3)
skills/cuopt-routing-api-python/BENCHMARK.mdskills/cuopt-routing-api-python/skill-card.mdskills/cuopt-routing-api-python/skill.oms.sig
| Top findings: | ||
|
|
||
| - MEDIUM SCHEMA/body_recommended_section: Missing recommended section: '## Instructions' (`skills/cuopt-routing-api-python/SKILL.md`) | ||
| - MEDIUM SECURITY/Unknown (SQP-2): Binding the cuOpt server to 0.0.0.0 exposes it on all network interfaces, making it accessible to any host that can reac (`references/server_examples.md:7`) |
There was a problem hiding this comment.
Fix truncated text.
The finding description is cut off mid-word. "reac" should be "reach".
✏️ Proposed fix
-- MEDIUM SECURITY/Unknown (SQP-2): Binding the cuOpt server to 0.0.0.0 exposes it on all network interfaces, making it accessible to any host that can reac (`references/server_examples.md:7`)
+- MEDIUM SECURITY/Unknown (SQP-2): Binding the cuOpt server to 0.0.0.0 exposes it on all network interfaces, making it accessible to any host that can reach (`references/server_examples.md:7`)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| - MEDIUM SECURITY/Unknown (SQP-2): Binding the cuOpt server to 0.0.0.0 exposes it on all network interfaces, making it accessible to any host that can reac (`references/server_examples.md:7`) | |
| - MEDIUM SECURITY/Unknown (SQP-2): Binding the cuOpt server to 0.0.0.0 exposes it on all network interfaces, making it accessible to any host that can reach (`references/server_examples.md:7`) |
🧰 Tools
🪛 LanguageTool
[grammar] ~72-~72: Ensure spelling is correct
Context: ...king it accessible to any host that can reac (references/server_examples.md:7) - L...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@skills/cuopt-routing-api-python/BENCHMARK.md` at line 72, Update the
truncated security finding text in BENCHMARK.md by replacing the truncated word
"reac" with the full word "reach" in the MEDIUM SECURITY/Unknown (SQP-2) entry
so the sentence reads "...making it accessible to any host that can reach
(references/server_examples.md:7)". Ensure no other words were accidentally
altered and run a quick spellcheck on that line.
Comment on lines
+63
to
+70
| | Dimension | Num | `claude-code` | `codex` | | ||
| |---|---:|---:|---:| | ||
| | Security | 2 | 100% (+0%) | 100% (+0%) | | ||
| | Correctness | 2 | 100% (+0%) | 95% (+3%) | | ||
| | Discoverability | 2 | 100% (+0%) | 70% (-5%) | | ||
| | Effectiveness | 2 | 83% (+14%) | 83% (+12%) | | ||
| | Efficiency | 2 | 93% (-0%) | 56% (-5%) | | ||
|
|
There was a problem hiding this comment.
Add blank line after the table.
The evaluation results table should be followed by a blank line before the next section heading to comply with Markdown formatting standards.
📝 Proposed fix
| Effectiveness | 2 | 83% (+14%) | 83% (+12%) |
| Efficiency | 2 | 93% (-0%) | 56% (-5%) |
+
## Skill Version(s): <br>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| | Dimension | Num | `claude-code` | `codex` | | |
| |---|---:|---:|---:| | |
| | Security | 2 | 100% (+0%) | 100% (+0%) | | |
| | Correctness | 2 | 100% (+0%) | 95% (+3%) | | |
| | Discoverability | 2 | 100% (+0%) | 70% (-5%) | | |
| | Effectiveness | 2 | 83% (+14%) | 83% (+12%) | | |
| | Efficiency | 2 | 93% (-0%) | 56% (-5%) | | |
| | Dimension | Num | `claude-code` | `codex` | | |
| |---|---:|---:|---:| | |
| | Security | 2 | 100% (+0%) | 100% (+0%) | | |
| | Correctness | 2 | 100% (+0%) | 95% (+3%) | | |
| | Discoverability | 2 | 100% (+0%) | 70% (-5%) | | |
| | Effectiveness | 2 | 83% (+14%) | 83% (+12%) | | |
| | Efficiency | 2 | 93% (-0%) | 56% (-5%) | | |
🧰 Tools
🪛 markdownlint-cli2 (0.22.1)
[warning] 63-63: Tables should be surrounded by blank lines
(MD058, blanks-around-tables)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@skills/cuopt-routing-api-python/skill-card.md` around lines 63 - 70, Add a
single blank line after the evaluation results Markdown table (the table
starting with "| Dimension | Num | `claude-code` | `codex` |") so there is an
empty line separating the table from the following section heading; update the
skill-card.md content immediately after that table to insert one newline before
the next heading or paragraph.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update with benchmark details