Fix RandomForestClassifier sklearn child metadata - #8291
Merged
rapids-bot[bot] merged 4 commits intoJun 25, 2026
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe PR updates cuML RandomForestClassifier CPU export so estimator-level class metadata is rewritten consistently, and extends sklearn import/export tests to verify top-level and per-estimator class attributes during conversion. ChangesRandomForestClassifier class metadata
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
jcrist
approved these changes
Jun 24, 2026
jcrist
left a comment
Member
There was a problem hiding this comment.
Nice fix. One question, but otherwise LGTM.
Contributor
Author
|
/merge |
This was referenced Jun 25, 2026
rapids-bot Bot
pushed a commit
that referenced
this pull request
Jun 26, 2026
This PR removes xfail markers that caused failures in nightly test: https://github.com/rapidsai/cuml/actions/runs/28229406180/job/83629207110 These tests pass now because of the following PRs merged yesterday: - #8290: Fixed `plot_pca_vs_fa_model_selection` and `plot_compare_gpr_krr` because it adds CPU fallbacks - #8291: Fixed `plot_forest_iris` Authors: - Jinsol Park (https://github.com/jinsolp) Approvers: - Divye Gala (https://github.com/divyegala) - Jim Crist-Harif (https://github.com/jcrist) URL: #8297
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
RandomForestClassifier.as_sklearn()so exported child estimators use sklearn-compatible encodedclasses_andn_classes_metadata, while the exported forest keeps the original labels.Adds coverage with non-contiguous classifier labels and compares the exported child estimator metadata against a fitted sklearn random forest.
Contributes to #8180.
Related to #8238.