Fallback unsupported cuml.accel PCA and KernelRidge cases to CPU - #8290
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe PR adds CPU-fallback checks for ChangesCPU fallback checks for PCA and KernelRidge
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
f4255e0 to
2b2d574
Compare
2b2d574 to
83a391f
Compare
|
/merge |
This PR removes xfail markers that caused failures in nightly test: https://github.com/rapidsai/cuml/actions/runs/28229406180/job/83629207110 These tests pass now because of the following PRs merged yesterday: - #8290: Fixed `plot_pca_vs_fa_model_selection` and `plot_compare_gpr_krr` because it adds CPU fallbacks - #8291: Fixed `plot_forest_iris` Authors: - Jinsol Park (https://github.com/jinsolp) Approvers: - Divye Gala (https://github.com/divyegala) - Jim Crist-Harif (https://github.com/jcrist) URL: #8297
This updates
cuml.accelto fall back to CPU for two sklearn-compatible cases that are unsupported on GPU:PCA(n_components=0)andKernelRidgewith non-string sklearn kernels. ThePCA(n_components=0)behavior could be emulated in cuML in a follow-up, but the practical benefit is likely small since it is mainly an edge-case parity behavior. This also documents the new fallback limitations.Contributes to #8180