Skip to content

Handle sklearn example OpenML dataset lookup failures - #8216

Merged
csadorf merged 5 commits into
NVIDIA:release/26.06from
csadorf:issue-8205-followup-openml-not-found
Jun 3, 2026
Merged

Handle sklearn example OpenML dataset lookup failures#8216
csadorf merged 5 commits into
NVIDIA:release/26.06from
csadorf:issue-8205-followup-openml-not-found

Conversation

@csadorf

@csadorf csadorf commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Treats sklearn.datasets._openml.OpenMLError as an external OpenML failure in sklearn example collection so missing OpenML datasets xfail instead of failing the examples job.

Follow-up to #8205

@csadorf csadorf added Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 3, 2026
@copy-pr-bot

copy-pr-bot Bot commented Jun 3, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@csadorf

This comment has been minimized.

@csadorf

This comment has been minimized.

@csadorf

csadorf commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

Checked the PR CI run at https://github.com/rapidsai/cuml/actions/runs/26862934916?pr=8216.

At commit 89f17b435b1ffc4a61af49c2e28c0cb016c4e064, the conda-python-sklearn-examples-tests job passed, and the log shows sklearn.datasets._openml.OpenMLError being handled as ExampleNetworkError rather than a hard pytest failure.

The debug workflow changes still need to be reverted before merge.

@csadorf
csadorf marked this pull request as ready for review June 3, 2026 04:58
@csadorf
csadorf requested a review from a team as a code owner June 3, 2026 04:58
@csadorf
csadorf requested a review from betatim June 3, 2026 04:58
@csadorf
csadorf merged commit 9a90493 into NVIDIA:release/26.06 Jun 3, 2026
45 of 46 checks passed
@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Summary by CodeRabbit

Release Notes

  • Tests
    • Improved handling of network-related errors in example collection to properly mark expected failures when network issues are encountered.

Walkthrough

Extended the example collector's network-error detection to recognize sklearn.datasets._openml.OpenMLError patterns. When this error appears in subprocess output, examples are marked as xfail with the appropriate network-error reason.

Changes

Network error detection

Layer / File(s) Summary
OpenML error pattern addition
python/cuml/cuml_accel_tests/upstream/scikit-learn/example_collector.py
Added "sklearn.datasets._openml.OpenMLError" to the network-error detection patterns list so OpenML failures trigger xfail handling.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • rapidsai/cuml#7960: Introduces network-failure detection logic in the same example_collector.py file that this PR extends.
  • rapidsai/cuml#8205: Extends network-error pattern detection in the same collector for sklearn/OpenML example runs.

Suggested labels

ci

Suggested reviewers

  • viclafargue
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: handling OpenML dataset lookup failures in sklearn examples.
Description check ✅ Passed The description is directly related to the changeset, explaining the purpose and context of treating OpenMLError as an external failure.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@csadorf
csadorf deleted the issue-8205-followup-openml-not-found branch June 3, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants