Skip to content

Handle OpenML checksum failures in sklearn examples - #8359

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
csadorf:issue-8358-ci-sklearn-examples-fail-on-openml-dataset-checksu
Jul 9, 2026
Merged

Handle OpenML checksum failures in sklearn examples#8359
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
csadorf:issue-8358-ci-sklearn-examples-fail-on-openml-dataset-checksu

Conversation

@csadorf

@csadorf csadorf commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Treats OpenML dataset checksum mismatches as network xfails in the scikit-learn examples runner.

Closes #8358

@csadorf
csadorf requested a review from a team as a code owner July 9, 2026 14:57
@csadorf csadorf added bug Something isn't working non-breaking Non-breaking change labels Jul 9, 2026
@csadorf
csadorf requested a review from jcrist July 9, 2026 14:57
@github-actions github-actions Bot added the Cython / Python Cython or Python issue label Jul 9, 2026
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 4975e7f3-6ec2-403b-a829-570ce2bf951d

📥 Commits

Reviewing files that changed from the base of the PR and between 4065bdc and 5b9c516.

📒 Files selected for processing (1)
  • python/cuml/cuml_accel_tests/upstream/scikit-learn/example_collector.py

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Improved handling of scikit-learn example failures caused by OpenML download issues.
    • These cases are now recognized as network-related errors and marked appropriately instead of being treated as hard test failures.

Walkthrough

This PR adds a new substring to the _NETWORK_ERROR_PATTERNS list in example_collector.py, enabling detection of OpenML MD5 checksum mismatch error messages so affected scikit-learn example test failures are classified as network errors and xfailed instead of failing.

Changes

Network error pattern update

Layer / File(s) Summary
Add OpenML checksum error pattern
python/cuml/cuml_accel_tests/upstream/scikit-learn/example_collector.py
Added a substring matching OpenML MD5 checksum mismatch messages to _NETWORK_ERROR_PATTERNS, causing matching failures to be treated as ExampleNetworkError and xfailed.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • rapidsai/cuml#8205: Both PRs modify the same _network_error_pattern detection logic in example_collector.py for OpenML-related failures.
  • rapidsai/cuml#8216: Both PRs update _NETWORK_ERROR_PATTERNS in example_collector.py to recognize OpenML-related lookup failures as network errors.

Suggested labels: ci, improvement

Suggested reviewers: viclafargue, jcrist, betatim

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the change to treat OpenML checksum failures as handled sklearn example errors.
Description check ✅ Passed The description is directly related to the checksum-mismatch xfail handling added in the examples runner.
Linked Issues check ✅ Passed The change matches #8358 by classifying OpenML MD5 checksum mismatches as network xfails instead of hard failures.
Out of Scope Changes check ✅ Passed The PR makes a narrowly scoped pattern update with no evident unrelated changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@jcrist

jcrist commented Jul 9, 2026

Copy link
Copy Markdown
Member

/merge

@rapids-bot
rapids-bot Bot merged commit ff52add into NVIDIA:main Jul 9, 2026
97 checks passed
@csadorf
csadorf deleted the issue-8358-ci-sklearn-examples-fail-on-openml-dataset-checksu branch July 9, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] sklearn examples fail on OpenML dataset checksum mismatches

4 participants