Skip to content

Xfail sklearn example requiring plotly - #8193

Merged
csadorf merged 1 commit into
NVIDIA:release/26.06from
csadorf:release-2606-xfail-sklearn-plotly
Jun 1, 2026
Merged

Xfail sklearn example requiring plotly#8193
csadorf merged 1 commit into
NVIDIA:release/26.06from
csadorf:release-2606-xfail-sklearn-plotly

Conversation

@csadorf

@csadorf csadorf commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Adds ensemble::plot_forest_hist_grad_boosting_comparison to the sklearn example xfail list because it requires the optional plotly dependency.

Closes #8191

@csadorf
csadorf requested a review from a team as a code owner June 1, 2026 15:24
@csadorf
csadorf requested a review from divyegala June 1, 2026 15:25
@csadorf csadorf added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 1, 2026
@copy-pr-bot

copy-pr-bot Bot commented Jun 1, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the Cython / Python Cython or Python issue label Jun 1, 2026
@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5c58d33b-c541-433f-9d36-d5f62dd548b4

📥 Commits

Reviewing files that changed from the base of the PR and between 35186bf and 8ba92ab.

📒 Files selected for processing (1)
  • python/cuml/cuml_accel_tests/upstream/scikit-learn/xfail-examples.yaml

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated test configuration to mark a scikit-learn example test as expected to fail when optional dependencies are unavailable.

Walkthrough

Updated the scikit-learn example test expectations configuration to mark ensemble::plot_forest_hist_grad_boosting_comparison as an expected failure when the optional plotly dependency is unavailable, preventing CI failures in test environments without plotly installed.

Changes

Test Expectation Configuration

Layer / File(s) Summary
Add missing plotly xfail entry
python/cuml/cuml_accel_tests/upstream/scikit-learn/xfail-examples.yaml
Added ensemble::plot_forest_hist_grad_boosting_comparison to the existing Missing optional dependency: plotly xfail entry, marking this upstream scikit-learn example test as expected to fail when plotly is not installed.

Estimated Code Review Effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly Related PRs

  • rapidsai/cuml#7960: Both PRs modify xfail-examples.yaml to add expected-failure entries for scikit-learn examples with missing optional dependencies, including plotly-related xfail configuration.

Suggested Labels

Cython / Python, ci

Suggested Reviewers

  • AyodeAwe
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding a scikit-learn example to xfail list due to plotly dependency requirement.
Description check ✅ Passed The description accurately explains the change: adding the example to xfail list because it requires plotly, and links to the related issue.
Linked Issues check ✅ Passed The PR successfully addresses issue #8191 by adding the failing example to the xfail list, which prevents CI failures when plotly is not installed.
Out of Scope Changes check ✅ Passed The single file modification is directly scoped to the objective: adding one example to the xfail list due to missing plotly dependency.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@csadorf
csadorf merged commit beba7db into NVIDIA:release/26.06 Jun 1, 2026
16 checks passed
@csadorf
csadorf deleted the release-2606-xfail-sklearn-plotly branch June 1, 2026 15:32
This was referenced Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants