Skip to content

CI Update xfail list - #7768

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
betatim:update-xfails
Feb 5, 2026
Merged

CI Update xfail list#7768
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
betatim:update-xfails

Conversation

@betatim

@betatim betatim commented Feb 5, 2026

Copy link
Copy Markdown
Contributor

I think what happened is that #7751 fixed something that used to lead to the check_do_not_raise_errors_in_init_or_set_params check failing. The reason we ended up seeing it in #7632 is that #7751 was merged before #7753 (and we didnt rerun the CI for that PR).

@betatim
betatim requested a review from a team as a code owner February 5, 2026 17:00
@betatim
betatim requested a review from csadorf February 5, 2026 17:00
@github-actions github-actions Bot added the Cython / Python Cython or Python issue label Feb 5, 2026
@coderabbitai

coderabbitai Bot commented Feb 5, 2026

Copy link
Copy Markdown
📝 Walkthrough

Summary by CodeRabbit

  • Tests
    • Updated sklearn compatibility test expectations for multiple estimators (including KMeans, LogisticRegression, SVC, PCA, TSNE, and UMAP) by removing expected failure checks for initialization and parameter setting operations, reflecting improved behavioral alignment with sklearn standards.

Walkthrough

Removes xfail expectations for "check_do_not_raise_errors_in_init_or_set_params" from multiple estimators in the sklearn compatibility test suite, broadening which checks are no longer expected to fail during initialization and parameter setting.

Changes

Cohort / File(s) Summary
Test Compatibility Configuration
python/cuml/tests/test_sklearn_compatibility.py
Removed xfail mappings for "check_do_not_raise_errors_in_init_or_set_params" from PER_ESTIMATOR_XFAIL_CHECKS for ~26 estimators including KMeans, KernelRidge, LogisticRegression, LinearRegression, Ridge, NearestNeighbors, SVC/SVR variants, PCA variants, TSNE, UMAP, Lasso, ElasticNet, clustering and Naive Bayes estimators. RandomForestRegressor entry retained.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

improvement, non-breaking

Suggested reviewers

  • csadorf
  • viclafargue
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'CI Update xfail list' clearly and concisely describes the main change: removing outdated xfail entries from the test compatibility checks.
Description check ✅ Passed The description explains why the xfail entries are being removed, referencing specific PRs that fixed the underlying issues.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jcrist jcrist added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 5, 2026

@jcrist jcrist left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@betatim

betatim commented Feb 5, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit 21949bc into NVIDIA:main Feb 5, 2026
108 checks passed
@betatim
betatim deleted the update-xfails branch February 6, 2026 09:20
dantegd added a commit to dantegd/cuml that referenced this pull request Feb 17, 2026
I think what happened is that NVIDIA#7751 fixed something that used to lead to the `check_do_not_raise_errors_in_init_or_set_params` check failing. The reason we ended up seeing it in NVIDIA#7632 is that NVIDIA#7751 was merged before NVIDIA#7753 (and we didnt rerun the CI for that PR).

Authors:
  - Tim Head (https://github.com/betatim)

Approvers:
  - Jim Crist-Harif (https://github.com/jcrist)
  - Simon Adorf (https://github.com/csadorf)

URL: NVIDIA#7768
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants