CI Update xfail list - #7768
Merged
Merged
Conversation
📝 WalkthroughSummary by CodeRabbit
WalkthroughRemoves xfail expectations for "check_do_not_raise_errors_in_init_or_set_params" from multiple estimators in the sklearn compatibility test suite, broadening which checks are no longer expected to fail during initialization and parameter setting. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
/merge |
csadorf
approved these changes
Feb 5, 2026
This was referenced Feb 6, 2026
dantegd
added a commit
to dantegd/cuml
that referenced
this pull request
Feb 17, 2026
I think what happened is that NVIDIA#7751 fixed something that used to lead to the `check_do_not_raise_errors_in_init_or_set_params` check failing. The reason we ended up seeing it in NVIDIA#7632 is that NVIDIA#7751 was merged before NVIDIA#7753 (and we didnt rerun the CI for that PR). Authors: - Tim Head (https://github.com/betatim) Approvers: - Jim Crist-Harif (https://github.com/jcrist) - Simon Adorf (https://github.com/csadorf) URL: NVIDIA#7768
This was referenced Mar 5, 2026
Merged
This was referenced Mar 23, 2026
This was referenced Apr 22, 2026
This was referenced May 5, 2026
This was referenced May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think what happened is that #7751 fixed something that used to lead to the
check_do_not_raise_errors_in_init_or_set_paramscheck failing. The reason we ended up seeing it in #7632 is that #7751 was merged before #7753 (and we didnt rerun the CI for that PR).