fix: GdnCuTileEngine import path in cutile conftest and _pygraph error msg - #513
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe PR updates the GDN backend error and linear attention test imports to use the current cuTile and FROST engine modules. ChangesLinear attention engine references
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@cudnn-ci-bot run frost |
|
🚀 Running mirror pipeline Branch: cudnn-gh/pr-513-cabb38a |
Two related issues both causing NameError / ImportError at test setup: 1. cutile conftest (1730 errors): imported GdnCuTileEngine and KdaCuTileEngine from cudnn.engines, but those classes live in cudnn.linear_attention.cutile. cudnn.engines.__getattr__ only resolves factory names from its MANIFEST (e.g. GdnEngines), not individual engine classes from sub-packages. 2. frost kernel tests (14 errors): GdnFrostEngine, KdaFrostEngine, and Gdn2FrostEngine were used in isinstance assertions without any import. All three are lazy-exported from cudnn.linear_attention.frost. Also update the user-facing example path in _pygraph.py to match. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
cabb38a to
ec907d1
Compare
|
@cudnn-ci-bot run frost |
|
🚀 Running mirror pipeline Branch: cudnn-gh/pr-513-ec907d1 |
Problem
test/python/linear_attention/cutile/conftest.pyimportsGdnCuTileEngineandKdaCuTileEnginefromcudnn.engines:However these classes are only exported from
cudnn.linear_attention.cutile. Thecudnn.engines.__getattr__only resolves factory names registered in its own MANIFEST (e.g.GdnEngines), not individual engine classes that live in sub-packages.This caused all 1730 tests in
test/python/linear_attention/cutile/to fail at setup withImportErrorin every nightly CI run.python/cudnn/_pygraph.pyhad the same wrong path in its user-facing error message.Fix
conftest.py:from cudnn.linear_attention.cutile import GdnCuTileEngine, KdaCuTileEngine_pygraph.py: update example path in error message to matchLabels
cat-bugfix, mod-linear-attention, orig-internal
Summary by CodeRabbit