Port revert of "Add FFT causal conv1d frontend bindings" (#437) to feat/frost_develop - #480
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Anerudhan
marked this pull request as ready for review
August 4, 2026 20:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the revert of #437 ("Add FFT causal conv1d frontend bindings") from
developover tofeat/frost_develop.#437 was reverted on
developby #479 (merged as05533fc5).feat/frost_developbranched fromdevelopatb5a068d4(the #437 merge commit), so it still carries the FFT causal conv1d code. This PR cherry-picks05533fc5onto it so the two branches agree.The cherry-pick is
-xrecorded and applied with no conflicts — the only commit onfeat/frost_developnot ondevelopis "Add GDN cuTile and FROST engines" (bbf3aa4a), which touches none of the files #437 changed.Verification
git diff 05533fc5 HEADis byte-identical togit diff b5a068d4 bbf3aa4a— i.e. after this revert, the only delta betweenfeat/frost_developand reverteddevelopis exactly the GDN cuTile/FROST engine work, unchanged.74785165, the commit immediately preceding Add FFT causal conv1d frontend bindings #437.Note: the
--statfor this cherry-pick reads+106 / -1669rather than #479's+14 / -1577. That is purely git's rewrite detection re-renderingtest/python/test_causal_conv1d.pyas a whole-file rewrite; the applied content is identical, as the two checks above confirm.Affected area
Related