Skip to content

Port revert of "Add FFT causal conv1d frontend bindings" (#437) to feat/frost_develop - #480

Merged
Anerudhan merged 1 commit into
NVIDIA:feat/frost_developfrom
Anerudhan:revert-437-frost
Aug 4, 2026
Merged

Port revert of "Add FFT causal conv1d frontend bindings" (#437) to feat/frost_develop#480
Anerudhan merged 1 commit into
NVIDIA:feat/frost_developfrom
Anerudhan:revert-437-frost

Conversation

@Anerudhan

Copy link
Copy Markdown
Collaborator

Summary

Ports the revert of #437 ("Add FFT causal conv1d frontend bindings") from develop over to feat/frost_develop.

#437 was reverted on develop by #479 (merged as 05533fc5). feat/frost_develop branched from develop at b5a068d4 (the #437 merge commit), so it still carries the FFT causal conv1d code. This PR cherry-picks 05533fc5 onto it so the two branches agree.

The cherry-pick is -x recorded and applied with no conflicts — the only commit on feat/frost_develop not on develop is "Add GDN cuTile and FROST engines" (bbf3aa4a), which touches none of the files #437 changed.

Verification

  • git diff 05533fc5 HEAD is byte-identical to git diff b5a068d4 bbf3aa4a — i.e. after this revert, the only delta between feat/frost_develop and reverted develop is exactly the GDN cuTile/FROST engine work, unchanged.
  • Every file touched by Add FFT causal conv1d frontend bindings #437 is byte-identical to its state at 74785165, the commit immediately preceding Add FFT causal conv1d frontend bindings #437.
  • No FROST/GDN files are modified by this PR.

Note: the --stat for this cherry-pick reads +106 / -1669 rather than #479's +14 / -1577. That is purely git's rewrite detection re-rendering test/python/test_causal_conv1d.py as a whole-file rewrite; the applied content is identical, as the two checks above confirm.

Affected area

  • Python API or bindings
  • C++ samples and documentation

Related

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f3324457-7800-4b01-9da0-5722048317ab

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@Anerudhan
Anerudhan marked this pull request as ready for review August 4, 2026 20:36
@Anerudhan
Anerudhan merged commit 3a66e46 into NVIDIA:feat/frost_develop Aug 4, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants