Revert "Add FFT causal conv1d frontend bindings (#437)" - #479
Merged
Anerudhan merged 1 commit intoAug 4, 2026
Merged
Conversation
This reverts commit b5a068d.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (15)
💤 Files with no reviewable changes (13)
📝 WalkthroughWalkthroughThe change removes FFT causal-convolution implementations, bindings, exports, samples, tests, and documentation. It also removes FP64 support from causal convolution and standardizes parameter-gradient accumulation on FP32. ChangesCausal convolution API removal
Causal convolution gradient behavior
Documentation and test updates
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Anerudhan
approved these changes
Aug 4, 2026
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting
pre-commit runand committed any formatting changes.Affected area
Summary
Revert #437 in full, removing the FFT causal-conv frontend shims, Python bindings, operation wrapper, samples, documentation, and tests. This also reverts the accompanying FP64 direct causal-conv changes.
Why
#437 enables the FFT causal-conv shims whenever
CUDNN_VERSION >= 92600. A cuDNN header set can report version 9.26 without declaring the five required FFT causal-conv APIs, causing frontend C++ compilation to fail before tests run.A full revert restores compatibility while the corresponding backend APIs remain unavailable. The frontend changes can be reapplied once that dependency is present, preferably using an explicit backend feature macro instead of a version-only compile guard.
Related issues
Reverts #437.
API and compatibility impact
This temporarily removes the APIs introduced by #437, including:
cudnn.ops.fft_causal_conv1dcudnnFFTCausalConv1dForwardcudnnFFTCausalConv1dBackwardcudnnLongFFTCausalConv1dGetBufferSizescudnnLongFFTCausalConv1dForwardcudnnLongFFTCausalConv1dBackwardThe revert restores the complete source tree to public commit
74785165de2da954a2c879a5e3e6f95411c2292d, immediately before #437.Testing
Both commands passed. The second command verifies that the reverted tree is identical to the public tree before #437.
No separate build or test suite was run locally; CI will provide build and test coverage.
Summary by CodeRabbit
Breaking Changes
Changes
Tests