test_mhas_v2: remove with_rope from randomized tests - #474
Merged
Conversation
RoPE fusion coverage lives in test_oss_rope.py; the randomized mhas tests should not gate on cuDNN version or exercise the rope path. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe unified randomized attention forward and backward tests no longer create RoPE configurations or apply cuDNN 9.24 RoPE compatibility skips. ChangesAttention test updates
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
vedaanta
marked this pull request as ready for review
August 4, 2026 05:48
Collaborator
Author
|
@cudnn-ci-bot run |
|
🚀 Running mirror pipeline Branch: cudnn-gh/pr-474-3c1cd83 |
Anerudhan
approved these changes
Aug 4, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
with_rope=RandomChoice(...)fromtest_sdpa_random_fwd_unified_L1andtest_sdpa_random_bwd_L0, and drop the cuDNN 9.24 version-guard skips.RoPE+SDPA coverage lives in
test/python/test_oss_rope.py. The randomized mhas tests should not gate on cuDNN version or randomly exercise the RoPE path.Closes GitLab MR !2296.
Summary by CodeRabbit