Skip to content

test_mhas_v2: remove with_rope from randomized tests - #474

Merged
vedaanta merged 1 commit into
NVIDIA:developfrom
vedaanta:rope-sdpa-engine
Aug 5, 2026
Merged

test_mhas_v2: remove with_rope from randomized tests#474
vedaanta merged 1 commit into
NVIDIA:developfrom
vedaanta:rope-sdpa-engine

Conversation

@vedaanta

@vedaanta vedaanta commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Remove with_rope=RandomChoice(...) from test_sdpa_random_fwd_unified_L1 and test_sdpa_random_bwd_L0, and drop the cuDNN 9.24 version-guard skips.

RoPE+SDPA coverage lives in test/python/test_oss_rope.py. The randomized mhas tests should not gate on cuDNN version or randomly exercise the RoPE path.

Closes GitLab MR !2296.

Summary by CodeRabbit

  • Tests
    • Updated randomized attention tests to run without RoPE configurations.
    • Removed version-based test skips related to RoPE generation.

RoPE fusion coverage lives in test_oss_rope.py; the randomized mhas
tests should not gate on cuDNN version or exercise the rope path.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 7a278202-259f-412d-8730-9e038baae621

📥 Commits

Reviewing files that changed from the base of the PR and between 7478516 and 3c1cd83.

📒 Files selected for processing (1)
  • test/python/test_mhas_v2.py
💤 Files with no reviewable changes (1)
  • test/python/test_mhas_v2.py

📝 Walkthrough

Walkthrough

The unified randomized attention forward and backward tests no longer create RoPE configurations or apply cuDNN 9.24 RoPE compatibility skips.

Changes

Attention test updates

Layer / File(s) Summary
Remove RoPE configuration handling
test/python/test_mhas_v2.py
The forward and backward tests no longer randomize with_rope or skip cuDNN 9.24-incompatible RoPE configurations.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: anerudhan

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the change and rationale, but it omits the required affected area, checklist, API impact, and testing sections. Add the template sections and state the affected area, checklist status, API compatibility impact, and exact testing commands and results.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the removal of with_rope from randomized MHAS tests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@vedaanta
vedaanta requested a review from Anerudhan August 4, 2026 05:48
@vedaanta
vedaanta marked this pull request as ready for review August 4, 2026 05:48
@vedaanta

vedaanta commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator Author

@cudnn-ci-bot run

@cudnn-ci-bot

Copy link
Copy Markdown

🚀 Running mirror pipeline

Branch: cudnn-gh/pr-474-3c1cd83
Pipeline: 61075703

@vedaanta vedaanta added orig-nv-eng Reported or requested by NVIDIA engineering. mod-frontend cuDNN frontend APIs, operation graph construction, plans, and user-facing wrappers. cat-enhancements labels Aug 4, 2026
@vedaanta vedaanta added this to the Frontend 1.27.0 milestone Aug 4, 2026
@vedaanta
vedaanta merged commit b7ddaae into NVIDIA:develop Aug 5, 2026
1 check passed
@Anerudhan Anerudhan mentioned this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cat-enhancements mod-frontend cuDNN frontend APIs, operation graph construction, plans, and user-facing wrappers. orig-nv-eng Reported or requested by NVIDIA engineering.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants