Fix causal conv1d test collection with older cuDNN - #472
Merged
yeliu-oss merged 1 commit intoAug 3, 2026
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughChangesCausal convolution test compatibility
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
yeliu-oss
marked this pull request as ready for review
August 3, 2026 15:44
vedaanta
approved these changes
Aug 3, 2026
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
getattr(cudnn, binding_name, None).Why
cuDNN builds older than 9.22 do not export these optional Python symbols. Referencing them directly in pytest parametrization raises
AttributeErrorduring module collection, before pytest can skip unsupported cases.Binding presence is the source of truth here, so the test does not duplicate effective cuDNN backend-version logic already enforced by the binding layer.
Validation
Built the current frontend branch from source twice against matched headers and runtime libraries from official packages:
nvidia-cudnn-cu13==9.22.0.52:cudnn.backend_version() == 92200;16 passednvidia-cudnn-cu13==9.24.0.43:cudnn.backend_version() == 92400;16 passedblack --check --line-length 160 --fast test/python/test_causal_conv1d.pygit diff --check origin/develop..HEADFixes #468
Summary by CodeRabbit