Skip to content

Fix causal conv1d test collection with older cuDNN - #472

Merged
yeliu-oss merged 1 commit into
NVIDIA:developfrom
yeliu-oss:yeliu/fix-issue-468-causal-conv1d-version-guard
Aug 3, 2026
Merged

Fix causal conv1d test collection with older cuDNN#472
yeliu-oss merged 1 commit into
NVIDIA:developfrom
yeliu-oss:yeliu/fix-issue-468-causal-conv1d-version-guard

Conversation

@yeliu-oss

@yeliu-oss yeliu-oss commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

What changed

  • Resolve causal-conv1d test bindings lazily with getattr(cudnn, binding_name, None).
  • Skip only parameter cases whose binding is absent from the frontend build.

Why

cuDNN builds older than 9.22 do not export these optional Python symbols. Referencing them directly in pytest parametrization raises AttributeError during module collection, before pytest can skip unsupported cases.

Binding presence is the source of truth here, so the test does not duplicate effective cuDNN backend-version logic already enforced by the binding layer.

Validation

Built the current frontend branch from source twice against matched headers and runtime libraries from official packages:

  • nvidia-cudnn-cu13==9.22.0.52: cudnn.backend_version() == 92200; 16 passed
  • nvidia-cudnn-cu13==9.24.0.43: cudnn.backend_version() == 92400; 16 passed
  • black --check --line-length 160 --fast test/python/test_causal_conv1d.py
  • git diff --check origin/develop..HEAD

Fixes #468

Summary by CodeRabbit

  • Tests
    • Improved causal convolution compatibility checks across cuDNN frontend builds.
    • Test cases now skip unavailable bindings while continuing to validate unsupported kernel-size handling.

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 4068190d-0aae-4d8c-95c9-8e18465a1874

📥 Commits

Reviewing files that changed from the base of the PR and between 073ce27 and 9a68611.

📒 Files selected for processing (1)
  • test/python/test_causal_conv1d.py

📝 Walkthrough

Walkthrough

Changes

Causal convolution test compatibility

Layer / File(s) Summary
Dynamic binding resolution
test/python/test_causal_conv1d.py
Parameterized cases now store binding names. The test resolves each binding with getattr and skips unavailable bindings while preserving unsupported kernel-size validation.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the fix for causal conv1d test collection with older cuDNN versions.
Description check ✅ Passed The description explains the change, cause, compatibility impact, validation results, and linked issue; omitted template sections are non-critical.
Linked Issues check ✅ Passed The lazy binding lookup and selective skipping directly resolve issue #468 by preventing collection failures on cuDNN versions without causal-conv1d bindings.
Out of Scope Changes check ✅ Passed The changes are limited to the causal conv1d Python test and directly support the linked issue objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@yeliu-oss
yeliu-oss marked this pull request as ready for review August 3, 2026 15:44
@yeliu-oss yeliu-oss self-assigned this Aug 3, 2026
@yeliu-oss yeliu-oss added orig-nv-eng Reported or requested by NVIDIA engineering. mod-frontend cuDNN frontend APIs, operation graph construction, plans, and user-facing wrappers. cat-bug Reports of incorrect behavior, crashes, regressions, or unexpected results. orig-qa Reported or owned by quality assurance, validation, or testing. cat-ci CI failures, test flakiness, workflow breakage, or automation issues. and removed orig-nv-eng Reported or requested by NVIDIA engineering. cat-bug Reports of incorrect behavior, crashes, regressions, or unexpected results. labels Aug 3, 2026
@yeliu-oss
yeliu-oss merged commit 1c362d0 into NVIDIA:develop Aug 3, 2026
1 check passed
@Anerudhan Anerudhan added this to the Frontend 1.27.0 milestone Aug 3, 2026
@yeliu-oss
yeliu-oss deleted the yeliu/fix-issue-468-causal-conv1d-version-guard branch August 3, 2026 20:38
@Anerudhan Anerudhan mentioned this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cat-ci CI failures, test flakiness, workflow breakage, or automation issues. mod-frontend cuDNN frontend APIs, operation graph construction, plans, and user-facing wrappers. orig-qa Reported or owned by quality assurance, validation, or testing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] python_tests:cudnn_9.19.0.56_13.1.0: [Ampere]/[Hopper]: test/python/test_causal_conv1d.py - AttributeError: causal_conv1d_forward

3 participants