Fix Rubin WGRAD compatibility across Blackwell CUTLASS wheels - #464
Merged
Conversation
Signed-off-by: qiyuw <qiyuw@nvidia.com>
…tream Rubin, and added MXFP8 discrete-accumulation coverage
Signed-off-by: qiyuw <qiyuw@nvidia.com>
Signed-off-by: qiyuw <qiyuw@nvidia.com>
Signed-off-by: qiyuw <qiyuw@nvidia.com>
Contributor
📝 WalkthroughWalkthroughThe grouped WGRAD kernel now detects the internal CUTLASS DSL, narrows FP4 layout recasting, routes C TMA metadata by GPU configuration, and accepts optional helper-kernel metadata. Rubin dispatch tests use the relocated path and skip unavailable Rubin helpers. ChangesGrouped WGRAD dispatch
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant HostDispatch
participant helper_kernel
participant RubinSM107
HostDispatch->>HostDispatch: Select DSL-specific layouts and TMA metadata
HostDispatch->>helper_kernel: Pass optional C TMA and epilogue metadata
helper_kernel->>RubinSM107: Rebuild metadata for Rubin or SM107
helper_kernel-->>HostDispatch: Use host metadata for other configurations
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Anerudhan
self-requested a review
July 31, 2026 21:16
Anerudhan
approved these changes
Jul 31, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting
pre-commit runand committed any formatting changes.Affected area
Summary
Why
Related issues
Related to #460
API and compatibility impact
Testing
Summary by CodeRabbit
Bug Fixes
Tests