BSA: remove dead SM100 block-128 fragment allocations - #392
Merged
Anerudhan merged 1 commit intoJul 16, 2026
Conversation
Contributor
📝 WalkthroughWalkthroughThe correction path removes intermediate vectorized softmax-scale setup and allocation, while changing ChangesCorrection rescale changes
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
jiayus-nvidia
marked this pull request as ready for review
July 15, 2026 08:10
Collaborator
|
@cudnn-ci-bot run |
|
🚀 Running mirror pipeline Branch: cudnn-gh/pr-392-f482017 |
Anerudhan
approved these changes
Jul 16, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tOrO_frgallocation that was unconditionally overwritten before use.make_rmem_tensorallocation to preserve the original fragment layout, dtype, and lifetime.Motivation
nvidia-cutlass-dsl4.6 removed the deprecated top-levelcute.make_fragmentAPI and privatecute.core.ThrMmatype. The BSA implementation hadalready migrated its live register tensors and type annotations to
cute.make_rmem_tensorandcute.ThrMma.That migration exposed several pre-existing dead allocations in the SM100 block-128 correction path. This change removes only those unused
constructs, following the cleanup in FlashInfer PR #3922.
No copies, barriers, reductions, indexing operations, TMEM loads/stores, or architecture instructions are changed.
Compatibility
Verified with:
nvidia-cutlass-dsl==4.5.2nvidia-cutlass-dsl==4.6.1The
block_sparse_attentiontree contains no remaining uses of:cute.make_fragment(...)cute.core.ThrMmacute.core.ThrCopyMMA object methods such as
make_fragment_A/B/Cremain unchanged because they are still valid public APIs.Validation
Tested on NVIDIA B200 / SM100:
17 passedwith CUTLASS DSL 4.5.2.17 passedwith CUTLASS DSL 4.6.1.python/cudnn/block_sparse_attentionparsed and imported successfully with both versions.git diff --checkpassed.The tests cover SM100 block-128 and block-64 forward/backward kernels. SM90 and SM120 modules were statically imported under both DSL versions but
were not executed because the validation machine was SM100.