Skip to content

Fix FE-OSS SDPA links and DSA diagram fence - #360

Merged
Anerudhan merged 1 commit into
NVIDIA:developfrom
pmdavies-nv:pdavies/fix-doc-links-dsa-fence
Jul 8, 2026
Merged

Fix FE-OSS SDPA links and DSA diagram fence#360
Anerudhan merged 1 commit into
NVIDIA:developfrom
pmdavies-nv:pdavies/fix-doc-links-dsa-fence

Conversation

@pmdavies-nv

@pmdavies-nv pmdavies-nv commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replace broken SDPA Markdown anchor links in docs/fe-oss-apis/overview.md with stable docs.nvidia.com URLs.
  • Mark the DSA architecture diagram code block as text in docs/fe-oss-apis/dsa.md.

Why

  • The prior ../operations/Attention.md#... links do not resolve to intended section anchors in GitHub and were causing strict docs-build reference issues downstream.
  • The untyped diagram block can be misinterpreted by syntax highlighters due to Unicode drawing characters.

Validation

  • Built downstream docs with warnings treated as errors after applying equivalent fixes.

Summary by CodeRabbit

  • Documentation
    • Clarified a code example formatting in the DSA docs for better readability.
    • Updated documentation links for SDPA Forward and SDPA Backward to point to the correct hosted references.

Use stable SDPA documentation URLs in overview and mark the DSA architecture block as text to avoid code highlighter parsing issues.
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a136e1e1-90e6-4aee-bd25-2702b4335372

📥 Commits

Reviewing files that changed from the base of the PR and between 6b6a822 and 832ac32.

📒 Files selected for processing (2)
  • docs/fe-oss-apis/dsa.md
  • docs/fe-oss-apis/overview.md

📝 Walkthrough

Walkthrough

Minor documentation updates: a code fence in dsa.md now specifies the text language identifier, and two SDPA Forward/Backward links in overview.md were changed from local relative anchors to external NVIDIA documentation URLs.

Changes

Documentation edits

Layer / File(s) Summary
Doc fence and link fixes
docs/fe-oss-apis/dsa.md, docs/fe-oss-apis/overview.md
Code fence language identifier added in dsa.md; SDPA Forward/Backward links in overview.md updated to external NVIDIA docs URLs.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Related issues: None specified.

Related PRs: None specified.

Suggested labels: documentation

Suggested reviewers: None specified.

🐰 A hop through docs, both crisp and clean,
A fence now marked as text is seen,
Two links now point where NVIDIA lives,
A tidy patch, small joy it gives.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the two main doc fixes: SDPA link updates and the DSA diagram fence change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@Anerudhan
Anerudhan merged commit 0c93f09 into NVIDIA:develop Jul 8, 2026
1 check passed
@pmdavies-nv
pmdavies-nv deleted the pdavies/fix-doc-links-dsa-fence branch July 8, 2026 01:38
@Anerudhan Anerudhan mentioned this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants