Add memory resource parameter to cudf::mark_join constructors - #23278
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test 0ae3e47 |
📝 WalkthroughSummary by CodeRabbit
Walkthrough
ChangesMark join memory resource support
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
cpp/tests/join/semi_anti_join_tests.cpp (1)
519-531: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winCover the load-factor constructor as well.
This test exercises only the first public constructor; the load-factor overload has an independent
mrforwarding path. Add a second case or parameterize the test to cover both.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@cpp/tests/join/semi_anti_join_tests.cpp` around lines 519 - 531, Extend MarkJoinMemoryResource to also construct cudf::mark_join through the public load-factor overload, passing the same memory resource and valid load-factor value, then verify the resource records allocation for that path as well. Preserve the existing constructor coverage and assertions.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@cpp/tests/join/semi_anti_join_tests.cpp`:
- Around line 519-531: Extend MarkJoinMemoryResource to also construct
cudf::mark_join through the public load-factor overload, passing the same memory
resource and valid load-factor value, then verify the resource records
allocation for that path as well. Preserve the existing constructor coverage and
assertions.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 487ee9a9-6357-424d-8762-0d3310d6b6fd
📒 Files selected for processing (4)
cpp/include/cudf/join/mark_join.hppcpp/src/join/mark_join.cucpp/src/join/mark_join.cuhcpp/tests/join/semi_anti_join_tests.cpp
|
/merge |
Description
Follow-up to #23264 and #23277.
This PR adds an
mrparameter to thecudf::mark_joinconstructors to control allocations for the persistent cuco hash table and optional bloom-filter prefilter, aligning the wrapper with the temporary MR effort (#20780).Checklist