Add memory resource parameter to cudf::key_remapping constructor - #23277
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test 85a48e3 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe ChangesKey remapping memory resource
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@cpp/tests/join/key_remapping_tests.cpp`:
- Around line 761-766: In the remap_right_keys test, add an assertion that ids
contains the expected number of rows before the indexed EXPECT_EQ and EXPECT_NE
checks. Keep the existing ID relationship assertions unchanged and ensure all
ids[0] through ids[3] accesses occur only after validating the output length.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 33a79d4d-4670-476d-98e2-ad9aae71443f
📒 Files selected for processing (3)
cpp/include/cudf/join/key_remapping.hppcpp/src/join/key_remapping.cucpp/tests/join/key_remapping_tests.cpp
|
@PointKernel needs a style fix. |
Follow-up to #23264 and #23277. This PR adds an `mr` parameter to the `cudf::mark_join` constructors to control allocations for the persistent cuco hash table and optional bloom-filter prefilter, aligning the wrapper with the temporary MR effort (#20780). Authors: - Yunsong Wang (https://github.com/PointKernel) Approvers: - David Wendt (https://github.com/davidwendt) - Qi Chen (https://github.com/qbacpey) URL: #23278
|
/merge |
Description
Follow-up to #23264.
This PR adds an
mrparameter to thecudf::key_remappingconstructor to control the memory usage of the internal cuco hash table, to better align with the temporary mr effort (#20780).Checklist