Skip to content

cudf-classic and CI cleanups for NumPy/CuPy 2/14 version bump - #23053

Merged
rapids-bot[bot] merged 4 commits into
NVIDIA:mainfrom
mroeschke:cudf/ref/np_2_fixes
Jul 1, 2026
Merged

cudf-classic and CI cleanups for NumPy/CuPy 2/14 version bump#23053
rapids-bot[bot] merged 4 commits into
NVIDIA:mainfrom
mroeschke:cudf/ref/np_2_fixes

Conversation

@mroeschke

Copy link
Copy Markdown
Contributor

Description

Follow up to #22962

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke self-assigned this Jun 30, 2026
@mroeschke
mroeschke requested review from a team as code owners June 30, 2026 22:49
@mroeschke
mroeschke requested a review from bdice June 30, 2026 22:49
@mroeschke mroeschke added the improvement Improvement / enhancement to an existing function label Jun 30, 2026
@mroeschke
mroeschke requested a review from TomAugspurger June 30, 2026 22:49
@mroeschke mroeschke added the non-breaking Non-breaking change label Jun 30, 2026
@github-actions github-actions Bot added Python Affects Python cuDF API. cudf.pandas Issues specific to cudf.pandas labels Jun 30, 2026
@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: fec899f9-b469-4b35-aa5d-e58e6a5057fb

📥 Commits

Reviewing files that changed from the base of the PR and between 939c8b5 and dbd773c.

📒 Files selected for processing (5)
  • python/cudf/cudf/api/extensions/accessor.py
  • python/cudf/cudf/core/frame.py
  • python/cudf/cudf/core/indexed_frame.py
  • python/cudf/cudf/core/series.py
  • python/cudf/cudf/tests/test_doctests.py
💤 Files with no reviewable changes (1)
  • python/cudf/cudf/tests/test_doctests.py
✅ Files skipped from review due to trivial changes (4)
  • python/cudf/cudf/core/frame.py
  • python/cudf/cudf/core/series.py
  • python/cudf/cudf/api/extensions/accessor.py
  • python/cudf/cudf/core/indexed_frame.py

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Improved compatibility handling so the pandas-compat test matrix runs consistently across supported environments.
    • Removed version-specific interval and doctest workarounds to align results with current NumPy behavior.
  • Tests
    • Updated the test runner to execute non-serial and profiler checks in separate passes per compatibility version.
  • Documentation
    • Refreshed doctest/docstring example outputs to consistently show NumPy scalar formatting (e.g., np.int64(...), np.float64(...)).

Walkthrough

The PR removes version-based compatibility branches from CI and tests, updates a NumPy wrapper import to be unconditional, and refreshes several docstring examples to show NumPy scalar formatting.

Changes

Remove version gating and refresh doctest output text

Layer / File(s) Summary
Version-gated compatibility code removed
ci/cudf_pandas_scripts/run_tests.sh, python/cudf/cudf/pandas/_wrappers/numpy.py, python/cudf/cudf/tests/indexes/test_interval.py, python/cudf/cudf/tests/test_doctests.py
The pandas-compat CI matrix runs for every configured version, flagsobj is imported unconditionally, interval tests drop NumPy-version dtype casting, and doctest setup removes the version-conditional printoptions path and skip constant.
Docstring outputs updated
python/cudf/cudf/api/extensions/accessor.py, python/cudf/cudf/core/frame.py, python/cudf/cudf/core/indexed_frame.py, python/cudf/cudf/core/series.py
Accessor, frame, indexed frame, and series docstrings update example outputs from plain Python scalars to np.int64(...) and np.float64(...) forms.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • rapidsai/cudf#22189: Both PRs modify ci/cudf_pandas_scripts/run_tests.sh’s pandas-compat CI matrix execution and the version_lte gating logic.
  • rapidsai/cudf#22706: Both PRs modify python/cudf/cudf/tests/test_doctests.py, changing doctest collection/output handling.

Suggested reviewers

  • jameslamb
  • wence-
  • galipremsagar
  • KyleFromNVIDIA
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 69.23% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main theme of the changes: NumPy/CuPy version-bump cleanup across CI and cudf-classic docs.
Description check ✅ Passed The description is clearly related as a follow-up to the referenced cudf PR and the changeset.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Comment thread python/cudf/cudf/tests/test_doctests.py Outdated
@@ -126,10 +117,7 @@ class TestDoctests:
def printoptions(cls):
# TODO: NumPy now prints scalars as `np.int8(1)`, etc. this should

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to fix this TODO while you're here? If it's hard, it's fine to defer on that.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appeared straightforward enough with an agent. Done in e50cbcb

@GPUtester GPUtester moved this to In Progress in cuDF Python Jun 30, 2026
@mroeschke

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit c3e1eea into NVIDIA:main Jul 1, 2026
130 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in cuDF Python Jul 1, 2026
@mroeschke
mroeschke deleted the cudf/ref/np_2_fixes branch July 1, 2026 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cudf.pandas Issues specific to cudf.pandas improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants