cudf-classic and CI cleanups for NumPy/CuPy 2/14 version bump - #23053
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (5)
💤 Files with no reviewable changes (1)
✅ Files skipped from review due to trivial changes (4)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe PR removes version-based compatibility branches from CI and tests, updates a NumPy wrapper import to be unconditional, and refreshes several docstring examples to show NumPy scalar formatting. ChangesRemove version gating and refresh doctest output text
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
| @@ -126,10 +117,7 @@ class TestDoctests: | |||
| def printoptions(cls): | |||
| # TODO: NumPy now prints scalars as `np.int8(1)`, etc. this should | |||
There was a problem hiding this comment.
Do you want to fix this TODO while you're here? If it's hard, it's fine to defer on that.
There was a problem hiding this comment.
Appeared straightforward enough with an agent. Done in e50cbcb
|
/merge |
Description
Follow up to #22962
Checklist