Skip to content

Fix mypy issue - #22549

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
wence-:wence/fix/mypy
May 18, 2026
Merged

Fix mypy issue#22549
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
wence-:wence/fix/mypy

Conversation

@wence-

@wence- wence- commented May 18, 2026

Copy link
Copy Markdown
Contributor

Description

This was missed while merging #22365

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@wence-
wence- requested a review from a team as a code owner May 18, 2026 17:33
@wence-
wence- requested a review from vyasr May 18, 2026 17:33
@github-actions github-actions Bot added Python Affects Python cuDF API. cudf-polars Issues specific to cudf-polars labels May 18, 2026
@GPUtester GPUtester moved this to In Progress in cuDF Python May 18, 2026
@coderabbitai

coderabbitai Bot commented May 18, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: ef0fc78c-94dd-4eb9-9f8c-39f9dd4eb865

📥 Commits

Reviewing files that changed from the base of the PR and between 96a466e and bb772e2.

📒 Files selected for processing (1)
  • python/cudf_polars/cudf_polars/experimental/benchmarks/utils_new_frontends.py

📝 Walkthrough

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated internal GPU benchmark runner configuration handling for improved benchmark execution clarity.

Walkthrough

Two benchmark runner functions now explicitly pass engine=None to _finalize_benchmark_run instead of omitting the parameter. Both call sites were reformatted into multiline argument lists for consistency and clarity.

Changes

Benchmark finalization calls

Layer / File(s) Summary
Benchmark finalization calls with explicit engine parameter
python/cudf_polars/cudf_polars/experimental/benchmarks/utils_new_frontends.py
run_polars_cpu and run_polars_in_memory explicitly pass engine=None to _finalize_benchmark_run and use multiline call formatting.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • rapidsai/cudf#22504: Both PRs touch utils_new_frontends.py and adjust how the benchmark runner passes/handles engine for CPU and in-memory backends through _finalize_benchmark_run.

Suggested labels

Python, improvement, cudf-polars

Suggested reviewers

  • pentschev
  • TomAugspurger
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Fix mypy issue' is vague and generic, using non-descriptive language that doesn't convey meaningful information about the specific changeset. Make the title more specific by describing what mypy issue was fixed, such as 'Fix mypy type checking by explicitly passing engine=None to _finalize_benchmark_run calls'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description is related to the changeset as it references a missed change from a prior merge, which aligns with the actual code modifications to fix a mypy issue.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@davidwendt davidwendt added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 18, 2026
@davidwendt

Copy link
Copy Markdown
Contributor

/merge

@rapids-bot
rapids-bot Bot merged commit f239649 into NVIDIA:main May 18, 2026
160 of 163 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in cuDF Python May 18, 2026
@wence-
wence- deleted the wence/fix/mypy branch May 18, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cudf-polars Issues specific to cudf-polars improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants