Fix misleading Javadoc for Aggregation.nth(int) - #22486
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR updates the Javadoc for Changesnth Aggregation Documentation Update
🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
6bf749c to
262ae67
Compare
|
/ok to test 262ae67 |
|
@davidwendt thanks for taking a look at this PR! CI fails with: This seems unrelated to the PR. Should I fix it in this PR? |
@piotrrzysko Yes. If you modify a file you are expected to update the copyright year at the top of that file. |
@piotrrzysko Please execute |
The comment stated "non-null element" but the method defaults to NullPolicy.INCLUDE, meaning NULL values can be returned.
262ae67 to
9c2ccdc
Compare
|
/ok to test 9c2ccdc |
|
Builds are failing. We just need to wait until they are working again. |
|
/ok to test b5cde3f |
|
/ok to test bb6f0b8 |
|
Thanks for fixing my mistake. |
|
Now waiting on #22549 to merge this |
|
/ok to test 351312f |
|
This PR is cursed. |
|
/merge |
Description
The comment stated "non-null element" but the method defaults to
NullPolicy.INCLUDE, meaning NULL values can be returned.Checklist