Skip to content

Increase alignment requirement for parquet bloom filter to 256 - #19595

Merged
AyodeAwe merged 9 commits into
NVIDIA:branch-25.08from
mhaseeb123:bloom-filter-alignment
Aug 5, 2025
Merged

Increase alignment requirement for parquet bloom filter to 256#19595
AyodeAwe merged 9 commits into
NVIDIA:branch-25.08from
mhaseeb123:bloom-filter-alignment

Conversation

@mhaseeb123

@mhaseeb123 mhaseeb123 commented Aug 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR cherry picks minor changes from PR #19573 to hotfix bloom filter alignment requirement in libcudf.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mhaseeb123
mhaseeb123 requested review from a team as code owners August 5, 2025 19:59
@mhaseeb123
mhaseeb123 requested review from devavret, kingcrimsontianyu, mroeschke and rjzamora and removed request for a team August 5, 2025 19:59
@copy-pr-bot

copy-pr-bot Bot commented Aug 5, 2025

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API. labels Aug 5, 2025
@mhaseeb123 mhaseeb123 changed the title Bloom-filter-alignment Increase alignment requirement for parquet bloom filter to 256 Aug 5, 2025
@GPUtester GPUtester moved this to In Progress in cuDF Python Aug 5, 2025
@mhaseeb123 mhaseeb123 added bug Something isn't working 5 - Ready to Merge Testing and reviews complete, ready to merge ! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround cuIO cuIO issue non-breaking Non-breaking change labels Aug 5, 2025
@mhaseeb123

mhaseeb123 commented Aug 5, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test

@mhaseeb123

mhaseeb123 commented Aug 5, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test 8c6fe32

@NVIDIA NVIDIA deleted a comment from copy-pr-bot Bot Aug 5, 2025
@AyodeAwe
AyodeAwe merged commit 0351218 into NVIDIA:branch-25.08 Aug 5, 2025
83 of 84 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in cuDF Python Aug 5, 2025
@mhaseeb123
mhaseeb123 deleted the bloom-filter-alignment branch August 5, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bdice bdice bdice approved these changes
@karthikeyann karthikeyann karthikeyann approved these changes
@shrshi shrshi shrshi approved these changes
@vuule vuule vuule approved these changes
@mroeschke mroeschke Awaiting requested review from mroeschke mroeschke was automatically assigned from rapidsai/cudf-python-codeowners
@rjzamora rjzamora Awaiting requested review from rjzamora rjzamora was automatically assigned from rapidsai/cudf-python-codeowners
@devavret devavret Awaiting requested review from devavret devavret was automatically assigned from rapidsai/cudf-cpp-codeowners
@kingcrimsontianyu kingcrimsontianyu Awaiting requested review from kingcrimsontianyu kingcrimsontianyu was automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@mhaseeb123 mhaseeb123

Labels

5 - Ready to Merge Testing and reviews complete, ready to merge ! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround bug Something isn't working cuIO cuIO issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@mhaseeb123 @bdice @karthikeyann @shrshi @vuule @caryr35 @GPUtester @AyodeAwe