Increase alignment requirement for parquet bloom filter to 256 - #19573
Merged
rapids-bot[bot] merged 11 commits intoAug 5, 2025
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
github-actions
Bot
added
libcudf
mhaseeb123
commented
Aug 2, 2025
mhaseeb123
added
bug
PointKernel
reviewed
Aug 4, 2025
davidwendt
approved these changes
Aug 4, 2025
Matt711
reviewed
Aug 4, 2025
PointKernel
approved these changes
Aug 4, 2025
Matt711
reviewed
Aug 4, 2025
Co-authored-by: Matthew Murray <41342305+Matt711@users.noreply.github.com>
mhaseeb123
added
5 - Ready to Merge
Matt711
reviewed
Aug 4, 2025
Contributor
Author
|
/merge |
3 tasks
AyodeAwe
pushed a commit
that referenced
this pull request
Aug 5, 2025
## Description This PR cherry picks minor changes from PR #19573 to hotfix bloom filter alignment requirement in libcudf. ## Checklist - [x] I am familiar with the [Contributing Guidelines](https://github.com/rapidsai/cudf/blob/HEAD/CONTRIBUTING.md). - [x] New or existing tests cover these changes. - [x] The documentation is up to date with these changes. --------- Co-authored-by: Matthew Murray <41342305+Matt711@users.noreply.github.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #19539. Related to rapidsai/rmm#2002
This PR increases the alignment requirement for parquet bloom filters from
32to256(== cuda allocation alignment) to avoid allocating invalid sized buffers and/or data corruption with aligned mr adapter. Doing so, doesn't really affect anything as 256 byte aligned addresses are also 32 byte aligned.Checklist