Add primitive row dispatch support for semi/anti join and cudf::contains - #19518
Merged
rapids-bot[bot] merged 6 commits intoJul 29, 2025
Merged
Conversation
PointKernel
added
libcudf
Contributor
|
Can you point out what is (new) fixed in this PR vs the original work please? |
bdice
approved these changes
Jul 28, 2025
bdice
left a comment
bdice
left a comment
Contributor
There was a problem hiding this comment.
Changes from the previous implementation look good. Thanks!
PointKernel
commented
Jul 28, 2025
Comment on lines
+57
to
+63
| // Only use primitive row operators for non-floating-point types since they don't handle NaN | ||
| // equality | ||
| auto const has_floating_point = | ||
| std::any_of(haystack.begin(), haystack.end(), [](auto const& col) { | ||
| return cudf::is_floating_point(col.type()); | ||
| }); | ||
| if (cudf::is_primitive_row_op_compatible(haystack) && !has_floating_point) { |
Member
Author
There was a problem hiding this comment.
@ttnghia voila
Primitive row operators are used only when the data type is an integer. A unit test has been added to cover this scenario as well
ttnghia
approved these changes
Jul 28, 2025
shrshi
approved these changes
Jul 28, 2025
Member
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is a follow-up to #19361, which was reverted due to a NaN handling bug and incorrect CG size used in explicit instantiations. This revised PR addresses those issues and retargets the work for the 25.10 release.
Checklist