Add primitive row dispatch support for semi/anti join and cudf::contains by tgujar · Pull Request #19361 · NVIDIA/cudf

tgujar · 2025-07-12T01:09:53Z

Description

Add primitive row operator for left semi/anti joins. This improves occupancy for join operations as detailed in #15700

Checklist

I am familiar with the Contributing Guidelines.
New or existing tests cover these changes.
The documentation is up to date with these changes.

copy-pr-bot · 2025-07-12T01:09:57Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

tgujar · 2025-07-12T01:10:27Z

Benchmark numbers

❯ python nvbench_compare.py ~/data_remote/repos/forks/cudf/main.json ~/data_remote/repos/forks/cudf/semi_test.json
['/home/tgujar/data_remote/repos/forks/cudf/main.json', '/home/tgujar/data_remote/repos/forks/cudf/semi_test.json']
# left_anti_join

## [0] NVIDIA H100 NVL

|  Key  |  Nullable  |  left_size  |  right_size  |   Ref Time |   Ref Noise |   Cmp Time |   Cmp Noise |        Diff |   %Diff |  Status  |
|-------|------------|-------------|--------------|------------|-------------|------------|-------------|-------------|---------|----------|
|  I32  |     0      |    1000     |     1000     |  64.963 us |       2.41% |  63.065 us |       1.68% |   -1.898 us |  -2.92% |   FAST   |
|  I32  |     0      |   100000    |     1000     |  71.572 us |       2.31% |  67.233 us |       2.60% |   -4.339 us |  -6.06% |   FAST   |
|  I32  |     0      |  10000000   |     1000     | 441.637 us |       0.33% | 308.310 us |       0.49% | -133.326 us | -30.19% |   FAST   |
|  I32  |     0      |   100000    |    100000    |  84.289 us |       1.24% |  81.270 us |       1.89% |   -3.019 us |  -3.58% |   FAST   |
|  I32  |     0      |  10000000   |    100000    | 535.629 us |       0.31% | 347.484 us |       0.58% | -188.145 us | -35.13% |   FAST   |
|  I32  |     0      |  10000000   |   10000000   |   1.352 ms |       0.12% |   1.001 ms |       0.18% | -351.054 us | -25.97% |   FAST   |
|  I32  |     1      |    1000     |     1000     |  64.966 us |       1.51% |  61.240 us |       2.00% |   -3.725 us |  -5.73% |   FAST   |
|  I32  |     1      |   100000    |     1000     |  69.565 us |       1.35% |  65.451 us |       1.46% |   -4.114 us |  -5.91% |   FAST   |
|  I32  |     1      |  10000000   |     1000     | 305.228 us |       0.85% | 221.829 us |       0.73% |  -83.399 us | -27.32% |   FAST   |
|  I32  |     1      |   100000    |    100000    |  73.267 us |       1.21% |  69.644 us |       2.78% |   -3.623 us |  -4.94% |   FAST   |
|  I32  |     1      |  10000000   |    100000    | 330.069 us |       0.42% | 235.873 us |       0.65% |  -94.195 us | -28.54% |   FAST   |
|  I32  |     1      |  10000000   |   10000000   | 709.609 us |       0.21% | 468.307 us |       0.31% | -241.301 us | -34.00% |   FAST   |
|  I64  |     0      |    1000     |     1000     |  70.909 us |       1.43% |  66.962 us |       1.40% |   -3.946 us |  -5.57% |   FAST   |
|  I64  |     0      |   100000    |     1000     |  76.788 us |       1.33% |  69.789 us |       1.29% |   -6.999 us |  -9.11% |   FAST   |
|  I64  |     0      |  10000000   |     1000     | 490.858 us |       0.38% | 336.470 us |       0.44% | -154.388 us | -31.45% |   FAST   |
|  I64  |     0      |   100000    |    100000    |  86.662 us |       1.26% |  79.595 us |       1.21% |   -7.067 us |  -8.15% |   FAST   |
|  I64  |     0      |  10000000   |    100000    | 544.787 us |       0.34% | 355.204 us |       0.44% | -189.583 us | -34.80% |   FAST   |
|  I64  |     0      |  10000000   |   10000000   |   1.421 ms |       0.11% |   1.075 ms |       0.13% | -346.447 us | -24.38% |   FAST   |
|  I64  |     1      |    1000     |     1000     |  64.618 us |       1.34% |  63.974 us |       1.44% |   -0.644 us |  -1.00% |   SAME   |
|  I64  |     1      |   100000    |     1000     |  69.150 us |       1.50% |  67.527 us |       1.23% |   -1.623 us |  -2.35% |   FAST   |
|  I64  |     1      |  10000000   |     1000     | 305.949 us |       0.51% | 229.717 us |       0.60% |  -76.232 us | -24.92% |   FAST   |
|  I64  |     1      |   100000    |    100000    |  73.244 us |       1.25% |  69.844 us |       1.42% |   -3.400 us |  -4.64% |   FAST   |
|  I64  |     1      |  10000000   |    100000    | 332.717 us |       0.44% | 239.780 us |       0.58% |  -92.937 us | -27.93% |   FAST   |
|  I64  |     1      |  10000000   |   10000000   | 723.276 us |       0.23% | 479.048 us |       0.33% | -244.228 us | -33.77% |   FAST   |

# left_semi_join

## [0] NVIDIA H100 NVL

|  Key  |  Nullable  |  left_size  |  right_size  |   Ref Time |   Ref Noise |   Cmp Time |   Cmp Noise |        Diff |   %Diff |  Status  |
|-------|------------|-------------|--------------|------------|-------------|------------|-------------|-------------|---------|----------|
|  I32  |     0      |    1000     |     1000     |  69.111 us |       1.72% |  66.564 us |       1.29% |   -2.547 us |  -3.69% |   FAST   |
|  I32  |     0      |   100000    |     1000     |  72.361 us |       1.55% |  67.765 us |       1.53% |   -4.595 us |  -6.35% |   FAST   |
|  I32  |     0      |  10000000   |     1000     | 436.516 us |       0.33% | 303.324 us |       0.44% | -133.191 us | -30.51% |   FAST   |
|  I32  |     0      |   100000    |    100000    |  84.024 us |       1.40% |  80.836 us |       1.25% |   -3.188 us |  -3.79% |   FAST   |
|  I32  |     0      |  10000000   |    100000    | 530.761 us |       0.26% | 342.551 us |       0.40% | -188.210 us | -35.46% |   FAST   |
|  I32  |     0      |  10000000   |   10000000   |   1.348 ms |       0.11% | 996.248 us |       0.14% | -351.450 us | -26.08% |   FAST   |
|  I32  |     1      |    1000     |     1000     |  65.360 us |       1.52% |  61.543 us |       1.37% |   -3.817 us |  -5.84% |   FAST   |
|  I32  |     1      |   100000    |     1000     |  69.502 us |       1.29% |  65.209 us |       1.35% |   -4.293 us |  -6.18% |   FAST   |
|  I32  |     1      |  10000000   |     1000     | 297.837 us |       0.48% | 215.431 us |       0.55% |  -82.406 us | -27.67% |   FAST   |
|  I32  |     1      |   100000    |    100000    |  72.982 us |       1.29% |  69.377 us |       1.63% |   -3.606 us |  -4.94% |   FAST   |
|  I32  |     1      |  10000000   |    100000    | 321.932 us |       0.54% | 229.511 us |       0.48% |  -92.421 us | -28.71% |   FAST   |
|  I32  |     1      |  10000000   |   10000000   | 702.780 us |       0.20% | 462.232 us |       0.30% | -240.548 us | -34.23% |   FAST   |
|  I64  |     0      |    1000     |     1000     |  71.306 us |       1.33% |  67.360 us |       1.42% |   -3.946 us |  -5.53% |   FAST   |
|  I64  |     0      |   100000    |     1000     |  76.351 us |       1.31% |  69.307 us |       1.35% |   -7.044 us |  -9.23% |   FAST   |
|  I64  |     0      |  10000000   |     1000     | 485.017 us |       0.28% | 331.038 us |       0.37% | -153.980 us | -31.75% |   FAST   |
|  I64  |     0      |   100000    |    100000    |  86.361 us |       1.30% |  79.207 us |       1.30% |   -7.154 us |  -8.28% |   FAST   |
|  I64  |     0      |  10000000   |    100000    | 540.600 us |       0.32% | 351.188 us |       0.45% | -189.412 us | -35.04% |   FAST   |
|  I64  |     0      |  10000000   |   10000000   |   1.417 ms |       0.10% |   1.070 ms |       0.13% | -347.190 us | -24.50% |   FAST   |
|  I64  |     1      |    1000     |     1000     |  65.254 us |       1.48% |  64.269 us |       1.41% |   -0.985 us |  -1.51% |   FAST   |
|  I64  |     1      |   100000    |     1000     |  68.653 us |       1.38% |  67.223 us |       2.98% |   -1.430 us |  -2.08% |   FAST   |
|  I64  |     1      |  10000000   |     1000     | 299.539 us |       0.38% | 222.513 us |       0.52% |  -77.026 us | -25.71% |   FAST   |
|  I64  |     1      |   100000    |    100000    |  72.967 us |       1.09% |  69.653 us |       1.50% |   -3.314 us |  -4.54% |   FAST   |
|  I64  |     1      |  10000000   |    100000    | 326.441 us |       0.39% | 232.851 us |       0.49% |  -93.589 us | -28.67% |   FAST   |
|  I64  |     1      |  10000000   |   10000000   | 717.637 us |       0.19% | 472.761 us |       0.26% | -244.876 us | -34.12% |   FAST   |

# Summary

- Total Matches: 48
  - Pass    (diff <= min_noise): 1
  - Unknown (infinite noise):    0
  - Failure (diff > min_noise):  **47**

PointKernel · 2025-07-15T17:20:17Z

/ok to test d041d8b

…emi-join

PointKernel · 2025-07-15T17:58:23Z

/ok to test dfe4413

PointKernel

LGTM

mhaseeb123

One optional minor suggestion but LGTM otherwise

davidwendt · 2025-07-17T12:36:24Z

Doesn't this double the compile-time for contains_table.cu?
Is the title of this PR correct? Seems like this is changes for cudf::contains and not join specifically.

PointKernel · 2025-07-17T17:35:16Z

Is the title of this PR correct? Seems like this is changes for cudf::contains and not join specifically.

Ha, makes sense. The goal was to enhance all join operations using primitive row operators, but since semi/anti joins rely on contains internally, this PR specifically updates contains. @tgujar, could you please gather benchmark results for contains as well and update the PR title to reflect that?

PointKernel · 2025-07-17T17:36:49Z

Doesn't this double the compile-time for contains_table.cu?

Yes, it does. I’ll fix it now. Putting this on hold in the meantime.

tgujar · 2025-07-18T00:02:26Z

Benchmark results for contains

['/home/tgujar/data_remote/repos/forks/cudf/cpp/build/benchmarks/main.json', '/home/tgujar/data_remote/repos/forks/cudf/cpp/build/benchmarks/test.json']
# contains_table

## [0] NVIDIA H100 PCIe

|      type       |  null_probability  |  table_size  |   Ref Time |   Ref Noise |   Cmp Time |   Cmp Noise |       Diff |   %Diff |  Status  |
|-----------------|--------------------|--------------|------------|-------------|------------|-------------|------------|---------|----------|
|       I32       |         0          |    10000     |  47.373 us |       2.25% |  45.562 us |       3.90% |  -1.811 us |  -3.82% |   FAST   |
|       I32       |        0.1         |    10000     |  49.000 us |       1.96% |  48.055 us |       1.72% |  -0.945 us |  -1.93% |   FAST   |
|       I32       |         0          |    100000    |  46.193 us |       1.75% |  44.717 us |       1.87% |  -1.476 us |  -3.20% |   FAST   |
|       I32       |        0.1         |    100000    |  48.462 us |       1.76% |  47.849 us |       1.91% |  -0.612 us |  -1.26% |   SAME   |
|       I32       |         0          |   1000000    |  52.373 us |       1.66% |  48.181 us |       1.73% |  -4.192 us |  -8.00% |   FAST   |
|       I32       |        0.1         |   1000000    |  64.982 us |       1.83% |  57.261 us |       1.89% |  -7.721 us | -11.88% |   FAST   |
|       I32       |         0          |   10000000   | 122.930 us |       0.65% |  87.830 us |       0.87% | -35.100 us | -28.55% |   FAST   |
|       I32       |        0.1         |   10000000   | 159.430 us |       0.72% | 110.844 us |       0.99% | -48.586 us | -30.47% |   FAST   |
| cudf::list_view |         0          |    10000     | 752.466 us |       0.19% | 751.824 us |       0.16% |  -0.643 us |  -0.09% |   SAME   |
| cudf::list_view |        0.1         |    10000     | 953.991 us |       0.09% | 953.573 us |       0.10% |  -0.418 us |  -0.04% |   SAME   |
| cudf::list_view |         0          |    100000    | 663.034 us |       0.22% | 664.170 us |       0.27% |   1.136 us |   0.17% |   SAME   |
| cudf::list_view |        0.1         |    100000    | 723.545 us |       0.36% | 724.876 us |       0.21% |   1.331 us |   0.18% |   SAME   |
| cudf::list_view |         0          |   1000000    |   3.322 ms |       0.14% |   3.325 ms |       0.15% |   2.433 us |   0.07% |   SAME   |
| cudf::list_view |        0.1         |   1000000    |   4.488 ms |       0.15% |   4.489 ms |       0.14% |   0.547 us |   0.01% |   SAME   |
| cudf::list_view |         0          |   10000000   |   1.927 ms |       0.32% |   1.925 ms |       0.28% |  -1.222 us |  -0.06% |   SAME   |
| cudf::list_view |        0.1         |   10000000   |   1.599 ms |       0.25% |   1.600 ms |       0.25% |   0.768 us |   0.05% |   SAME   |

# Summary

- Total Matches: 16
  - Pass    (diff <= min_noise): 9
  - Unknown (infinite noise):    0
  - Failure (diff > min_noise):  7

…emi-join

Co-authored-by: Muhammad Haseeb <14217455+mhaseeb123@users.noreply.github.com>

…emi-join

…ive-semi-join

PointKernel · 2025-07-18T18:04:41Z

/ok to test a301142

vyasr

Cmake approval

…emi-join

PointKernel · 2025-07-18T20:19:45Z

/ok to test fb3f147

PointKernel · 2025-07-21T17:16:10Z

/ok to test 2c16dd9

PointKernel · 2025-07-22T17:25:09Z

As discussed offline, we’ve decided to merge this PR into 25.08 since the risk of performance regression is minimal.

PointKernel · 2025-07-22T17:25:21Z

/merge

…ins (#19518) This PR is a follow-up to #19361, which was reverted due to a NaN handling bug and incorrect CG size used in explicit instantiations. This revised PR addresses those issues and retargets the work for the 25.10 release. Authors: - Yunsong Wang (https://github.com/PointKernel) Approvers: - Bradley Dice (https://github.com/bdice) - Nghia Truong (https://github.com/ttnghia) - Shruti Shivakumar (https://github.com/shrshi) URL: #19518

add primitive dispatch support for semi join

d038c81

tgujar requested a review from a team as a code owner July 12, 2025 01:09

tgujar requested review from mythrocks and nvdbaranec July 12, 2025 01:09

github-actions Bot assigned tgujar Jul 12, 2025

github-actions Bot added the libcudf Affects libcudf (C++/CUDA) code. label Jul 12, 2025

fix formatting

1dc1bb5

GregoryKimball requested a review from PointKernel July 15, 2025 16:36

Merge branch 'branch-25.08' into semi-join-occupancy

d041d8b

github-actions Bot assigned PointKernel Jul 15, 2025

PointKernel added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function Performance Performance related issue labels Jul 15, 2025

PointKernel added 2 commits July 15, 2025 10:57

Add docs

1ddea81

Merge remote-tracking branch 'upstream/branch-25.08' into primitive-s…

dfe4413

…emi-join

PointKernel approved these changes Jul 16, 2025

View reviewed changes

mhaseeb123 approved these changes Jul 16, 2025

View reviewed changes

Comment thread cpp/include/cudf/table/primitive_row_operators.cuh

mhaseeb123 reviewed Jul 17, 2025

View reviewed changes

Comment thread cpp/include/cudf/table/primitive_row_operators.cuh Outdated

PointKernel added the DO NOT MERGE Hold off on merging; see PR for details label Jul 17, 2025

tgujar changed the title ~~Add primitive row dispatch support for semi/anti join~~ Add primitive row dispatch support for semi/anti join and cudf::contains Jul 17, 2025

PointKernel and others added 2 commits July 18, 2025 09:39

Merge remote-tracking branch 'upstream/branch-25.08' into primitive-s…

e8fd443

…emi-join

Update cpp/include/cudf/table/primitive_row_operators.cuh

851ac44

Co-authored-by: Muhammad Haseeb <14217455+mhaseeb123@users.noreply.github.com>

PointKernel added 3 commits July 18, 2025 11:01

Add missing files

c54897b

Merge remote-tracking branch 'upstream/branch-25.08' into primitive-s…

bb06ff4

…emi-join

Merge remote-tracking branch 'tanmay/semi-join-occupancy' into primit…

a301142

…ive-semi-join

PointKernel requested a review from a team as a code owner July 18, 2025 18:04

github-actions Bot added the CMake CMake build issue label Jul 18, 2025

PointKernel added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed DO NOT MERGE Hold off on merging; see PR for details labels Jul 18, 2025

vyasr approved these changes Jul 18, 2025

View reviewed changes

ttnghia reviewed Jul 18, 2025

View reviewed changes

Comment thread cpp/src/search/contains_table_impl.cu Outdated

ttnghia reviewed Jul 18, 2025

View reviewed changes

Comment thread cpp/src/search/contains_table_impl.cu Outdated

ttnghia reviewed Jul 18, 2025

View reviewed changes

Comment thread cpp/src/search/contains_table_impl_nested.cu Outdated

PointKernel added 2 commits July 18, 2025 13:18

Type alias renaming

b0354bf

Merge remote-tracking branch 'upstream/branch-25.08' into primitive-s…

fb3f147

…emi-join

ttnghia approved these changes Jul 18, 2025

View reviewed changes

PointKernel moved this to Burndown in libcudf Jul 21, 2025

PointKernel added this to libcudf Jul 21, 2025

Merge branch 'branch-25.08' into semi-join-occupancy

2c16dd9

PointKernel mentioned this pull request Jul 21, 2025

Add multi-column support for primitive row operator dispatch #18940

Merged

3 tasks

PointKernel moved this from Burndown to Slip in libcudf Jul 21, 2025

rapids-bot Bot merged commit 421d9ac into NVIDIA:branch-25.08 Jul 22, 2025

GregoryKimball moved this from Slip to Landed in libcudf Jul 22, 2025

This was referenced Jul 25, 2025

Revert "Add primitive row dispatch support for semi/anti join and cudf::contains" #19503

Merged

Add primitive row dispatch support for semi/anti join and cudf::contains #19518

Merged

GregoryKimball removed this from libcudf Sep 3, 2025

Uh oh!

Conversation

tgujar commented Jul 12, 2025

Description

Checklist

Uh oh!

copy-pr-bot Bot commented Jul 12, 2025

Uh oh!

tgujar commented Jul 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PointKernel commented Jul 15, 2025

Uh oh!

PointKernel commented Jul 15, 2025

Uh oh!

PointKernel left a comment

Choose a reason for hiding this comment

Uh oh!

mhaseeb123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

davidwendt commented Jul 17, 2025

Uh oh!

PointKernel commented Jul 17, 2025

Uh oh!

PointKernel commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tgujar commented Jul 18, 2025

Uh oh!

PointKernel commented Jul 18, 2025

Uh oh!

vyasr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PointKernel commented Jul 18, 2025

Uh oh!

PointKernel commented Jul 21, 2025

Uh oh!

PointKernel commented Jul 22, 2025

Uh oh!

PointKernel commented Jul 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

tgujar commented Jul 12, 2025 •

edited

Loading

PointKernel commented Jul 17, 2025 •

edited

Loading