Refactor distinct join to use primitive row operators when proper - #17726
Merged
rapids-bot[bot] merged 22 commits intoMay 13, 2025
Conversation
PointKernel
added
2 - In Progress
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
github-actions
Bot
added
Python
PointKernel
removed
Python
PointKernel
changed the title
PointKernel
added
3 - Ready for Review
PointKernel
marked this pull request as ready for review
May 8, 2025 20:59
Member
Author
|
/ok to test 03adc0b |
davidwendt
approved these changes
May 12, 2025
mhaseeb123
approved these changes
May 12, 2025
mhaseeb123
reviewed
May 12, 2025
Member
Author
|
/merge |
Member
Author
|
/ok to test 3d37b69 |
Member
Author
|
/ok to test da73099 |
This was referenced May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces primitive row hashers and equality comparators and apply them into distinct hash joins to reduce register pressure and enhance runtime performance. It's an alternative to the 3-way dispatching row operators proposed in #15700, avoiding the build time issues associated with the original proposal. Testing shows that the new primitive row operators improve runtime performance in most scenarios, with architecture-dependent gains of up to 30%.
Checklist