Occupancy improvement for distinct hash join with specialized dispatch - #17290
Closed
tgujar wants to merge 3 commits into
Closed
Occupancy improvement for distinct hash join with specialized dispatch #17290tgujar wants to merge 3 commits into
tgujar wants to merge 3 commits into
Conversation
PointKernel
self-requested a review
November 9, 2024 03:08
PointKernel
added
breaking
wence-
reviewed
Nov 11, 2024
Member
|
/ok to test |
Contributor
|
@PointKernel @tgujar is this PR still needed? I'm not sure how it fits in with #15700 and #17726 |
Member
|
Closing this PR as it is superseded by #17726 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MR adds specialized dispatch for distinct hash join insert and probe operations to avoid high occupancy cost of complex data types.
This is a split of the original MR #15700 so that its easier to review and merge. It contains all the changes from previous comments on relevant files.
Addresses #15502 for distinct hash joins
Checklist