Skip to content

Replace is not None checks for linker flags with booleans #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpcloud merged 2 commits into from
Sep 19, 2025
Merged

Replace is not None checks for linker flags with booleans #989

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a31f6b
Replace is not None checks for linker flags with booleans
mmason-nvidia Sep 19, 2025
61a5fad
Merge branch 'main' into mmason-nvidia/bugfix/linker-flags
leofang Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions cuda_core/cuda/core/experimental/_linker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,17 +203,17 @@ def _init_nvjitlink(self):
self.formatted_options.append(f"-maxrregcount={self.max_register_count}")
if self.time is not None:
self.formatted_options.append("-time")
if self.verbose is not None:
if self.verbose:
self.formatted_options.append("-verbose")
if self.link_time_optimization is not None and self.link_time_optimization:
if self.link_time_optimization:
self.formatted_options.append("-lto")
if self.ptx is not None:
if self.ptx:
self.formatted_options.append("-ptx")
if self.optimization_level is not None:
self.formatted_options.append(f"-O{self.optimization_level}")
if self.debug is not None and self.debug:
if self.debug:
self.formatted_options.append("-g")
if self.lineinfo is not None and self.lineinfo:
if self.lineinfo:
self.formatted_options.append("-lineinfo")
if self.ftz is not None:
self.formatted_options.append(f"-ftz={'true' if self.ftz else 'false'}")
Expand Down Expand Up @@ -273,21 +273,21 @@ def _init_driver(self):
self.option_keys.append(_driver.CUjit_option.CU_JIT_MAX_REGISTERS)
if self.time is not None:
raise ValueError("time option is not supported by the driver API")
if self.verbose is not None:
if self.verbose:
self.formatted_options.append(1)
self.option_keys.append(_driver.CUjit_option.CU_JIT_LOG_VERBOSE)
if self.link_time_optimization is not None:
if self.link_time_optimization:
self.formatted_options.append(1)
self.option_keys.append(_driver.CUjit_option.CU_JIT_LTO)
if self.ptx is not None:
if self.ptx:
raise ValueError("ptx option is not supported by the driver API")
if self.optimization_level is not None:
self.formatted_options.append(self.optimization_level)
self.option_keys.append(_driver.CUjit_option.CU_JIT_OPTIMIZATION_LEVEL)
if self.debug is not None:
if self.debug:
self.formatted_options.append(1)
self.option_keys.append(_driver.CUjit_option.CU_JIT_GENERATE_DEBUG_INFO)
if self.lineinfo is not None:
if self.lineinfo:
self.formatted_options.append(1)
self.option_keys.append(_driver.CUjit_option.CU_JIT_GENERATE_LINE_INFO)
if self.ftz is not None:
Expand Down
Loading